Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fee should be applied for oracle transactions #1214

Closed
4 tasks
robert-zaremba opened this issue Aug 4, 2022 · 1 comment · Fixed by #1326
Closed
4 tasks

Small fee should be applied for oracle transactions #1214

robert-zaremba opened this issue Aug 4, 2022 · 1 comment · Fixed by #1326
Assignees
Milestone

Comments

@robert-zaremba
Copy link
Member

robert-zaremba commented Aug 4, 2022

Summary

Add static fee limit for price transactions.

Nice to have for v3, can be pushed back to v4.

Problem Definition

Today, the oracle price transactions can be provided for free as long as the gas per message is in the MaxOracleMsgGasUsage limit.

Proposal

For keeping the process more sustainable we need to add additional fee mechanism, with a lower limit than #1017
Might be 0.001umee per message. For reference, bank send tx cost about 0.005-0.01umee, and price feed transaction is a bit more resource intensive.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added this to the v3 - Calypso milestone Aug 4, 2022
@robert-zaremba robert-zaremba self-assigned this Aug 4, 2022
@robert-zaremba robert-zaremba changed the title Small fee should be applied for price transactions Small fee should be applied for oracle transactions Aug 31, 2022
@robert-zaremba
Copy link
Member Author

Thinking more about it... Even if we enforce a small fee then this won't prevent accessing a state for free (because this is happening in CheckTx phase - so before we can charge any fee).
So my conclusion is to keep oracle tx for free (with current rules: checking gas limit and tx is only oracle messages) and optimize the CheckTx by using cache (added new issue for that: #1327) to prevent state access.

mergify bot pushed a commit that referenced this issue Sep 8, 2022
## Description

Closes: #1214

This is a "v1" solution for requiring min-gas price. More flexible mechanism ([#1017](#1017)) we will develop for v4 (or v5).

Notes:
+ added `fee-notes.md` files with stats for the fees.

---

### Author Checklist

_All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues._

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] added appropriate labels to the PR
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

_All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items._

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant