From 4863e474c9520f4746925d1d10571ad175bc3ba8 Mon Sep 17 00:00:00 2001
From: zthxxx <zthxxx.me@gmail.com>
Date: Fri, 7 Aug 2020 11:31:00 +0800
Subject: [PATCH] feat: add default 404 for gen conventional routes

---
 .../core/src/Route/getConventionalRoutes.ts   | 52 +++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/packages/core/src/Route/getConventionalRoutes.ts b/packages/core/src/Route/getConventionalRoutes.ts
index 653b65c2ab1d..d3e78fc36bc3 100644
--- a/packages/core/src/Route/getConventionalRoutes.ts
+++ b/packages/core/src/Route/getConventionalRoutes.ts
@@ -170,6 +170,56 @@ function normalizeRoutes(routes: IRoute[]): IRoute[] {
   );
 }
 
+export const find404Route = (routes: IRoute[]): IRoute | null => {
+  for (const route of routes) {
+    if (route.path === '/404') {
+      return route;
+    }
+    if (route.routes) {
+      return find404Route(route.routes);
+    }
+  }
+
+  return null;
+}
+
+export const nestedAddDefault404 = (routes: IRoute[], notFoundRoute: IRoute) => {
+  for (const route of routes) {
+    if (route.routes) {
+      nestedAddDefault404(route.routes, notFoundRoute);
+    }
+  }
+
+  routes.push(notFoundRoute);
+}
+
+/**
+ * 为约定式路由中添加默认 404 路由
+ *
+ * 在能找到约定 404 路由组件 (如 `/404.tsx`) 的情况下，
+ * 给嵌套路由中的每一项 routes 末尾添加不匹配任何 path 的 404 路由
+ */
+export const addConventional404 = (routes: IRoute[]) => {
+  const notFoundRoute = find404Route(routes);
+
+  if (!notFoundRoute) {
+    return
+  }
+
+  if (!notFoundRoute.component && !notFoundRoute.redirect) {
+    throw new Error('Invalid route config for /404, no component and redirect');
+  }
+
+  const { component, redirect } = notFoundRoute;
+
+  nestedAddDefault404(
+    routes,
+    notFoundRoute.component
+      ? { component }
+      : { redirect },
+  );
+}
+
 export default function getRoutes(opts: IOpts) {
   const { root, relDir = '', config } = opts;
   const files = getFiles(join(root, relDir));
@@ -197,5 +247,7 @@ export default function getRoutes(opts: IOpts) {
     }
   }
 
+  addConventional404(routes);
+
   return routes;
 }