Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong FileType Resolution for Form Type Templates #36

Open
thedamnedrhino opened this issue Jun 20, 2017 · 2 comments
Open

Wrong FileType Resolution for Form Type Templates #36

thedamnedrhino opened this issue Jun 20, 2017 · 2 comments

Comments

@thedamnedrhino
Copy link

I was getting a php syntax error running the script. After some digging I found out that it was because I had a FormType.php.twig file in the directory, which the script in turn attempted to parse as a php file and not a twig file.

@umpirsky
Copy link
Owner

Ouch, nice find!

Never expected to run this on non PHP files.

Can be fixed by adding $finder->name('*.php') in https://github.com/umpirsky/Symfony-Upgrade-Fixer/blob/master/src/Symfony/Upgrade/Console/Command/FixCommand.php#L107

Thanks!

@thedamnedrhino
Copy link
Author

Ofcourse.
Thank you for the great package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants