From 2faf9dc4ef3dc4b25693e5a3fa878552999f755b Mon Sep 17 00:00:00 2001
From: arpentnoir <namlleps.drahcir@gmail.com>
Date: Wed, 28 Jun 2023 20:58:16 +1000
Subject: [PATCH] chore: test todo action

---
 packages/cli/default/default.yml                       | 10 ++++++++++
 .../src/__tests__/issue-verify-flow.test.ts            |  6 ++++++
 2 files changed, 16 insertions(+)

diff --git a/packages/cli/default/default.yml b/packages/cli/default/default.yml
index 3da4282e..8a35cd38 100644
--- a/packages/cli/default/default.yml
+++ b/packages/cli/default/default.yml
@@ -174,6 +174,16 @@ didResolver:
       sov:
         $ref: /universal-resolver
 
+#  TODO: remove hardcoded infura project ID
+ 
+#  this is referencing someone else's infura project that could
+#  be shut down at any point, breaking any functionality that requires
+#  eth interactions. 
+ 
+#  worth searching the rest of the codebase at the same time as 
+#  fixing this, there are several other references in demo-explorer, 
+#  and tests...
+
 ethr-did-resolver:
   $require: ethr-did-resolver?t=function&p=/ethr#getResolver
   $args:
diff --git a/packages/credential-ld/src/__tests__/issue-verify-flow.test.ts b/packages/credential-ld/src/__tests__/issue-verify-flow.test.ts
index c279315b..e38fb2b0 100644
--- a/packages/credential-ld/src/__tests__/issue-verify-flow.test.ts
+++ b/packages/credential-ld/src/__tests__/issue-verify-flow.test.ts
@@ -36,6 +36,12 @@ const customContext: Record<string, ContextDoc> = {
   },
 }
 
+// TODO: remove infura dependency in tests
+// 
+// not great having external dependency in test
+// these tests should be refactored to not rely on 
+// external service
+
 const infuraProjectId = '3586660d179141e3801c3895de1c2eba'
 
 describe('credential-LD full flow', () => {