Agregando grupos a new datasets #31
Open
+57
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdata99
reviewed
Dec 10, 2024
Comment on lines
28
to
32
| </select> | ||
| </div> | ||
|
|
||
| <!-- Grup list --> | ||
| {% set groups_available = h.groups_available('create_dataset') %} |
There was a problem hiding this comment.
groups_available ya fue definido en la vista. Esta disponible en el contexto
Suggested change
| </select> | |
| </div> | |
| <!-- Grup list --> | |
| {% set groups_available = h.groups_available('create_dataset') %} | |
| </select> | |
| </div> | |
| <!-- Grup list --> |
avdata99
reviewed
Dec 10, 2024
Comment on lines
38
to
39
| <input class="form-check-input" type="checkbox" id="group_{{ group.id }}" name="ckan_group_id" value="{{ group.id }}" | ||
| {% if group.id in selected_groups %}checked{% endif %}> |
There was a problem hiding this comment.
Suggested change
| <input class="form-check-input" type="checkbox" id="group_{{ group.id }}" name="ckan_group_id" value="{{ group.id }}" | |
| {% if group.id in selected_groups %}checked{% endif %}> | |
| <input class="form-check-input" type="checkbox" id="group_{{ group.id }}" name="ckan_group_id" value="{{ group.id }}"> |
Nunca va a haber grupos preseleccionados. Siempre vamos a estar creando un dataset nuevo. Hay que sacar tambien selected_groups de la vista que llama a este templata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #29
Se agrega la funsión para que alcrear un datases a traves del superset se pueda agregar a un grupo determinado o a varios.