feat: Adding unit test for Slack API interactions using testify/mock #26
Conversation
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 6.60% 16.71% +10.10%
==========================================
Files 9 9
Lines 348 347 -1
==========================================
+ Hits 23 58 +35
+ Misses 325 288 -37
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Give me a bit to get a handle on this... I'm actually working toward #5 right now, by way of somewhat similar tactics. Given that I'm working in a whole new |
UFF perfect. Let me know! I will leave this PR open, just in case. |
|
@JoseAngel1196 This is showing out-of-date with |
Done! 😄 |
|
|
||
| func TestSendSlackMessagesSuccess(t *testing.T) { | ||
| // Create a mock Slack client | ||
| mockClient := new(MockSlackClient) |
There was a problem hiding this comment.
Ah interesting I've never seen the new() function used. I've always opted for literals instead like mockClient := MockSlackClient{}. No need for change here, just found this interesting!
Changes Made
In this pull request, I have added unit tests for Slack API using testify/mock.
Description
Previously, we were facing difficulties in adding unit tests due to tight coupling with the Slack API, which made it challenging to mock and test our code independently.
To address this issue, I have implemented encapsulation by defining an interface for the Slack API and implementing its methods by referencing the external package. Now, our package consumers (e.g., scan.go) can use the interface without needing to directly import the 'go-path/to/external' package, which helps decouple our code from the external dependency. Additionally, I have introduced a factory method to abstract the implementation details of the Slack Client.
With these changes, we can now easily mock the Slack API interface for unit testing, improving the testability and maintainability of our code.