Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-13756 add inflections import #474

Merged
merged 4 commits into from
May 25, 2020
Merged

CLDR-13756 add inflections import #474

merged 4 commits into from
May 25, 2020

Conversation

macchiati
Copy link
Member

Checklist

@macchiati
Copy link
Member Author

Note: change to English are just putting the file in canonical order.

@macchiati macchiati marked this pull request as ready for review May 24, 2020 02:55
@macchiati
Copy link
Member Author

I just finished the work to import the provisional data.
I'd like to get this in so that I can test on smoketest asap.

There are two kinds of cases:

  1. There is draft data for new units, but no casing information (eg ko). Plus draft data for gender of new and some old units (for languages with gender, such as fr).
  2. TEST-12063: Blueberries #1 plus draft data for casing information for new and some old units. (eg de or pl)

Example for # 1

{0}영국 쿼트

As a part of doing this, I found and fixed the problem in display of the cased information in smoketest.

  1. The TestPathHeader wasn't testing a more complicated language like German, so fixed that.
  2. It exposed that the PathHeader.txt was not doing the case attributes properly, so fixed that.
  3. Also added a new class PathChecker.java to check validity of paths, and called it in CLDRModify, so that new paths added by CLDRModify are checked before addition.

@macchiati macchiati merged commit 05e6aa0 into unicode-org:master May 25, 2020
@macchiati macchiati deleted the CLDR-13756-Add-inflections-import branch May 25, 2020 21:11
This was referenced Aug 27, 2021
Open
Merged
movermeyer added a commit to movermeyer/ruby-cldr that referenced this pull request Aug 27, 2021
@movermeyer
Ignore plural cases of units for now
fea3aab 
[This PR](unicode-org/cldr#474) added information about cases for pluralization of units.
This code was not ready for that, and started returning whichever happened to be that last case in the section.

For now, we'll just return the case-less version as we always did.
movermeyer added a commit to movermeyer/ruby-cldr that referenced this pull request Nov 9, 2021
@movermeyer
Ignore plural cases of units for now
7ee6cc7 
[This PR](unicode-org/cldr#474) added information about cases for pluralization of units.
This code was not ready for that, and started returning whichever happened to be that last case in the section.

For now, we'll just return the case-less version as we always did.
movermeyer added a commit to movermeyer/ruby-cldr that referenced this pull request Nov 10, 2021
@movermeyer
Ignore plural cases of units for now
9131c1a 
[This PR](unicode-org/cldr#474) added information about cases for pluralization of units.
This code was not ready for that, and started returning whichever happened to be that last case in the section.

For now, we'll just return the case-less version as we always did.
movermeyer added a commit to movermeyer/ruby-cldr that referenced this pull request Nov 17, 2021
@movermeyer
Ignore plural cases of units for now
cfe18fb 
[This PR](unicode-org/cldr#474) added information about cases for pluralization of units.
This code was not ready for that, and started returning whichever happened to be that last case in the section.

For now, we'll just return the case-less version as we always did.
movermeyer added a commit to movermeyer/ruby-cldr that referenced this pull request Dec 6, 2021
@movermeyer
Ignore plural cases of units for now
ef3756a 
[This PR](unicode-org/cldr#474) added information about cases for pluralization of units.
This code was not ready for that, and started returning whichever happened to be that last case in the section.

For now, we'll just return the case-less version as we always did.
movermeyer added a commit to movermeyer/ruby-cldr that referenced this pull request Feb 24, 2022
@movermeyer
Ignore plural cases of units for now
27dba4a 
[This PR](unicode-org/cldr#474) added information about cases for pluralization of units.
This code was not ready for that, and started returning whichever happened to be that last case in the section.

For now, we'll just return the case-less version as we always did.
movermeyer added a commit to movermeyer/ruby-cldr that referenced this pull request Feb 24, 2022
@movermeyer
Ignore plural cases of units for now
399fdf5 
[This PR](unicode-org/cldr#474) added information about cases for pluralization of units.
This code was not ready for that, and started returning whichever happened to be that last case in the section.

For now, we'll just return the case-less version as we always did.
movermeyer added a commit to movermeyer/ruby-cldr that referenced this pull request Feb 24, 2022
@movermeyer
Ignore plural cases of units for now
3d009e8 
[This PR](unicode-org/cldr#474) added information about cases for pluralization of units.
This code was not ready for that, and started returning whichever happened to be that last case in the section.

For now, we'll just return the case-less version as we always did.
movermeyer added a commit to ruby-i18n/ruby-cldr that referenced this pull request Apr 21, 2022
@movermeyer
Ignore plural cases of units for now
38a8335 
[This PR](unicode-org/cldr#474) added information about cases for pluralization of units.
This code was not ready for that, and started returning whichever happened to be that last case in the section.

For now, we'll just return the case-less version as we always did.
movermeyer added a commit to ruby-i18n/ruby-cldr that referenced this pull request Apr 21, 2022
@movermeyer
Ignore plural cases of units for now
809a304 
[This PR](unicode-org/cldr#474) added information about cases for pluralization of units.
This code was not ready for that, and started returning whichever happened to be that last case in the section.

For now, we'll just return the case-less version as we always did.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btangmu btangmu btangmu approved these changes

@pedberg-icu pedberg-icu Awaiting requested review from pedberg-icu

@srl295 srl295 Awaiting requested review from srl295

@Kristi27 Kristi27 Awaiting requested review from Kristi27

Assignees

@btangmu btangmu

Labels
in-production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macchiati @btangmu @pedberg-icu