-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds multi-OS support to travis CI #124
Conversation
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
=========================================
- Coverage 95.98% 95.9% -0.08%
=========================================
Files 9 8 -1
Lines 448 440 -8
=========================================
- Hits 430 422 -8
Misses 18 18
Continue to review full report at Codecov.
|
not sure why this build is failing: |
|
* fix windows ci * fix osx ci
@cosmicBboy please re-review, I've had help from @bensaxby to resolve the test failures. This PR extends CI support from Linux to also include Windows and osX/macOS by:
Separate to enabling multi-OS support, I believe we should specify specific environments and packages as is achieved here: i.e. we would adopt:
and those get substituted into a specific conda At the moment, because we only specify the "minimum" package versions, when the conda environment is rebuilt on CI runs, there's a risk that a change in a new version of a dependency would break the CI Pipeline. |
I think Codecov is misreporting the coverage issue and can be bypassed/ignored. |
@mastersplinter looking good to me! looks like flake8 is complaining:
|
will ignore code coverage drop, looks like a non-issue |
sorry about that - flake8 compliance was a silly miss on my part - I've updated. FYI I've opened a bug report on the TravisCI Community documenting the specific issue with the way Python on macOS images on Travis report their terminal width. @cosmicBboy should be good to go |
Adds multi-OS Support to address #109
This requires a few changes to the current approach: