Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin multimethod dep version (#1485) #1486

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

schatimo
Copy link
Contributor

@schatimo schatimo commented Feb 6, 2024

Solves #1485.

Signed-off-by: schatimo <tschaefer@mailbox.org>
@cosmicBboy
Copy link
Collaborator

thanks @schatimo !

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4df61da) 94.29% compared to head (173123d) 94.29%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1486   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files          91       91           
  Lines        7024     7024           
=======================================
  Hits         6623     6623           
  Misses        401      401           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosmicBboy
Copy link
Collaborator

oh, would you mind updating environment.yml with the version pin, then:

make nox-ci-requirements nox-dev-requirements requirements-docs.txt

This will update all dependency-related files for dev, ci, and doc requirements

Signed-off-by: schatimo <tschaefer@mailbox.org>
@schatimo
Copy link
Contributor Author

schatimo commented Feb 6, 2024

Sure, I updated the environment.yml and requirements.in files.

@cosmicBboy
Copy link
Collaborator

@schatimo do you mind giving me push permissions to your fork of pandera? Need to add updated deps to ci, dev, and docs dependency files.

@cosmicBboy
Copy link
Collaborator

cosmicBboy commented Feb 8, 2024

looks like I have read permissions, but unable to push

@cosmicBboy ➜ /workspaces/pandera-schatimo (test) $ git push origin test
remote: Permission to schatimo/pandera.git denied to cosmicBboy.
fatal: unable to access 'https://github.com/schatimo/pandera/': The requested URL returned error: 403

You'll have to give me perms to write

@schatimo
Copy link
Contributor Author

schatimo commented Feb 8, 2024

I can only add you as collaborator but cannot be more specific on the access rights I give to you. If it's easier, I can also close the PR and you open a new one where you make the changes needed?

@cosmicBboy
Copy link
Collaborator

under Settings > Collaborators and teams can you see if there's a Role dropdown?
image

@schatimo
Copy link
Contributor Author

schatimo commented Feb 8, 2024

There is no dropdown for me, only the role "Collaborator" by default, as my fork is outside an organization which would allow me to have a role concept (if I understand it correctly). And I guess checking out to branch bugfix/1485 and then pushing the changes does not work either, as you were trying to publish a new branch test.

@cosmicBboy
Copy link
Collaborator

nevermind got it to work, thanks!

@cosmicBboy
Copy link
Collaborator

merging this now, congrats on your first PR to pandera! 🚀

@cosmicBboy cosmicBboy merged commit 731a113 into unionai-oss:main Feb 8, 2024
56 checks passed
@glatterf42
Copy link

Thanks for taking care of this so quickly! Do you have any estimate on when 0.18.1 (or so) will be released that includes this fix?

@matheussecco
Copy link

Hi guys! Thanks for taking care of the issue. Do you have any idea of when a new version will be made available dealing with this dependency on multimethod?

@cosmicBboy
Copy link
Collaborator

will cut a bugfix release this weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants