-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pin multimethod dep version (#1485) #1486
Conversation
Signed-off-by: schatimo <tschaefer@mailbox.org>
thanks @schatimo ! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1486 +/- ##
=======================================
Coverage 94.29% 94.29%
=======================================
Files 91 91
Lines 7024 7024
=======================================
Hits 6623 6623
Misses 401 401 ☔ View full report in Codecov by Sentry. |
oh, would you mind updating
This will update all dependency-related files for dev, ci, and doc requirements |
Signed-off-by: schatimo <tschaefer@mailbox.org>
Sure, I updated the |
@schatimo do you mind giving me push permissions to your fork of pandera? Need to add updated deps to ci, dev, and docs dependency files. |
looks like I have read permissions, but unable to push
You'll have to give me perms to write |
I can only add you as collaborator but cannot be more specific on the access rights I give to you. If it's easier, I can also close the PR and you open a new one where you make the changes needed? |
There is no dropdown for me, only the role "Collaborator" by default, as my fork is outside an organization which would allow me to have a role concept (if I understand it correctly). And I guess checking out to branch |
nevermind got it to work, thanks! |
merging this now, congrats on your first PR to pandera! 🚀 |
Thanks for taking care of this so quickly! Do you have any estimate on when 0.18.1 (or so) will be released that includes this fix? |
Hi guys! Thanks for taking care of the issue. Do you have any idea of when a new version will be made available dealing with this dependency on multimethod? |
will cut a bugfix release this weekend |
Solves #1485.