senate membership updates for the 115th Congress #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konklone
approved these changes
Dec 17, 2016
|
Approved, but then I noticed tests were failing for what look like legit reasons. |
|
Yeah there's a datetime.now() call in the new validation script that won't let it pass until Jan 3 actually comes around, and the missing bioguide IDs. |
JoshData
force-pushed
the
115th_Congress_Senate
branch
2 times, most recently
from
760ff9c
to
5e698af
Compare
* added bioguide ids for new senators by guessing bioguide.congress.gov urls using our bioguide_guess_new_member_ids.py tool * ran scripts/election_results_senate_2016.py * ran scripts/sweep.py (renamed from sweep_memberships and now also sweeps the social media file)
…so that we can test changes that are staged for later
JoshData
force-pushed
the
115th_Congress_Senate
branch
from
5e698af
to
a58fa6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of senate changes for the 115th Congress.
Bioguide IDs for the new senators have not yet been assigned so that's missing. Otherwise it should be good to merge on Jan 3. If something else comes ahead of this PR, the GovTrack IDs might need to be re-done.
I ran:
see #375 and h/t to @mrumsky who started the senate elections google doc that I started from