Skip to content

Commit 93bc645

Browse files
committed
fix: brute force delete retry
1 parent 854da5b commit 93bc645

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

cumulus_lambda_functions/cumulus_wrapper/query_collections.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,12 +222,12 @@ def delete_executions(self, new_collection: dict, private_api_prefix: str):
222222
return {'client_error': query_result}
223223
query_result = json.loads(query_result['body'])
224224
LOGGER.debug(f'json query_result: {query_result}')
225-
if 'message' not in query_result:
225+
if 'id' not in query_result:
226226
return {'server_error': f'invalid response: {query_result}'}
227227
except Exception as e:
228228
LOGGER.exception('error while invoking')
229229
return {'server_error': f'error while invoking:{str(e)}'}
230-
return {'status': query_result['message']}
230+
return {'status': query_result}
231231

232232
def create_sqs_rules(self, new_collection: dict, private_api_prefix: str, sqs_url: str, provider_name: str = '', workflow_name: str = 'CatalogGranule', visibility_timeout: int = 1800):
233233
"""

cumulus_lambda_functions/uds_api/dapa/collections_dapa_creation.py

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,12 +179,23 @@ def delete(self):
179179
exec_delete_err, exec_delete_result = self.analyze_cumulus_result(executions_delete_result)
180180
deletion_result['cumulus_executions_deletion'] = exec_delete_err if exec_delete_err is not None else exec_delete_result
181181
sleep(10)
182-
rule_deletion_result = self.__cumulus_collection_query.delete_sqs_rules(cumulus_collection_doc, self.__cumulus_lambda_prefix)
183-
rule_delete_err, rule_delete_result = self.analyze_cumulus_result(rule_deletion_result)
184-
deletion_result['cumulus_rule_deletion'] = rule_delete_err if rule_delete_err is not None else rule_delete_result
185182
delete_result = self.__cumulus_collection_query.delete_collection(self.__cumulus_lambda_prefix, cumulus_collection_doc['name'], cumulus_collection_doc['version'])
186183
delete_err, delete_result = self.analyze_cumulus_result(delete_result)
184+
if delete_err is not None:
185+
executions_delete_result = self.__cumulus_collection_query.delete_executions(cumulus_collection_doc,
186+
self.__cumulus_lambda_prefix)
187+
exec_delete_err, exec_delete_result = self.analyze_cumulus_result(executions_delete_result)
188+
deletion_result[
189+
'cumulus_executions_deletion'] = exec_delete_err if exec_delete_err is not None else exec_delete_result
190+
sleep(10)
191+
delete_result = self.__cumulus_collection_query.delete_collection(self.__cumulus_lambda_prefix,
192+
cumulus_collection_doc['name'],
193+
cumulus_collection_doc['version'])
194+
delete_err, delete_result = self.analyze_cumulus_result(delete_result)
187195
deletion_result['cumulus_collection_deletion'] = delete_err if delete_err is not None else delete_result
196+
rule_deletion_result = self.__cumulus_collection_query.delete_sqs_rules(cumulus_collection_doc, self.__cumulus_lambda_prefix)
197+
rule_delete_err, rule_delete_result = self.analyze_cumulus_result(rule_deletion_result)
198+
deletion_result['cumulus_rule_deletion'] = rule_delete_err if rule_delete_err is not None else rule_delete_result
188199
else:
189200
deletion_result['cumulus_executions_deletion'] = 'NA'
190201
deletion_result['cumulus_rule_deletion'] = 'NA'

0 commit comments

Comments
 (0)