fix: passing cidr blocks from variable

Author: wphyojpl

tf-module/stac_browser/ec2.tf

@@ -42,7 +42,7 @@ resource "aws_security_group" "ds_stac_browser_security_group" {
 
 resource "aws_vpc_security_group_ingress_rule" "ds_stac_browser_security_group_443_10" {
   security_group_id = aws_security_group.ds_stac_browser_security_group.id
-  cidr_ipv4         = "10.52.0.0/16"
+  cidr_ipv4         = var.alb_subnet_cidr
   from_port         = 8005
   ip_protocol       = "tcp"
   to_port           = 8005

tf-module/stac_browser/load_balancer.tf

@@ -7,7 +7,7 @@ resource "aws_security_group" "ds_alb_security_group" {
 
 resource "aws_vpc_security_group_ingress_rule" "ds_alb_security_group_443_10" {
   security_group_id = aws_security_group.ds_alb_security_group.id
-  cidr_ipv4         = "10.52.0.0/16"
+  cidr_ipv4         = var.shared_services_ec2_subnet_cidr
   from_port         = 8005
   ip_protocol       = "tcp"
   to_port           = 8005

tf-module/stac_browser/terraform.tfvars.example

@@ -3,3 +3,5 @@ ami_id = "ami-xxx"
 cumulus_lambda_vpc_id = "vpc-xxx"
 image_tag="9.6.0"
 subnet_ids = ["subnet-private-subnet-id-1", "subnet-private-subnet-id-2"]
+shared_services_ec2_subnet_cidr = "10.52.0.0/16"
+alb_subnet_cidr = "10.52.0.0/16"

tf-module/stac_browser/variables.tf

@@ -43,4 +43,14 @@ variable "github_image_url" {
 variable "image_tag" {
   description = "The tag of the image to pull from GitHub"
   type        = string
+}
+
+variable "shared_services_ec2_subnet_cidr" {
+  type = string
+  description = "CIDR of the Subnet where Shared Services EC2 resides. This is to allow connections from Shared services to ALB. Example: 10.52.0.0/16"
+}
+
+variable "alb_subnet_cidr" {
+  type        = string
+  description = "CIDR of the Subnet where ALB resides. This is to allow connections from ALB to Stac Browser EC2. Example: 10.52.0.0/16"
 }