Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being passed
{ port: '0' }
({ port: string }
) is a Typescript type error, but we explicitly have a test that checks that it is gracefully handled, with behavior matching being passed{ port: 0 }
({ port: number }
),'0'
(string
), or0
(number
),which all convert the
port
to0
.However, that test was actually dependent on the following leak from a test above it:
Switching to
vi.stubEnv
and ensuring to callvi.unstubAllEnvs
reveals that the behavior is broken.This updates the behavior to apply the same check to
_userOptions.port
as we do to_userOptions
, and coercenumber
andstring
values to integers.