Remove some more network requests #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SVG is too big for IE 8 data uri, so we need to pass an option to less to confirm we do not need that support.
Browsers load them anyway, so we should save the extra network request.
kabel
changed the title
|
Looks like you're missing a new line at the end of your print.less file |
|
Nope. It's there. If it wasn't there, GitHub would say so at the end of the diff. |
|
Weird. When viewing a file in GitHub it doesn't show the final line. I never noticed that before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes 2 network requests for css related items (print sheet and large SVG image).