Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Avoid LINQ in TextBlock.UpdateHyperlinks #15805

Closed
Tracked by #8597
Youssef1313 opened this issue Mar 8, 2024 · 0 comments · Fixed by #16987
Closed
Tracked by #8597

[Performance] Avoid LINQ in TextBlock.UpdateHyperlinks #15805

Youssef1313 opened this issue Mar 8, 2024 · 0 comments · Fixed by #16987
Labels
area/performance 📈 Categorizes an issue or PR as relevant to performance area/textblock Categorizes an issue or PR as relevant to the TextBlock control difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification

Comments

@Youssef1313
Copy link
Member

Current behavior

This causes unnecessary allocations

image

Note: the allocation happens regardless of whether the TextBlock actually has a hyperlink. It happens whenever the TextBlock doesn't use fast path (i.e, when it has non-null _inlines)

Expected behavior

No response

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@Youssef1313 Youssef1313 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. area/textblock Categorizes an issue or PR as relevant to the TextBlock control area/performance 📈 Categorizes an issue or PR as relevant to performance kind/enhancement New feature or request and removed kind/bug Something isn't working labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance 📈 Categorizes an issue or PR as relevant to performance area/textblock Categorizes an issue or PR as relevant to the TextBlock control difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant