Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: GetWinUIThemeResourceUrl shouldn't format a string #11991

Merged

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): #8597

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Youssef1313 Youssef1313 force-pushed the GetWinUIThemeResourceUrl-format branch from 9be7d49 to 8471381 Compare April 15, 2023 20:35
Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jeromelaban jeromelaban merged commit 7fcf75f into unoplatform:master Apr 18, 2023
@Youssef1313 Youssef1313 deleted the GetWinUIThemeResourceUrl-format branch April 18, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants