-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add vee-validate
#85
Conversation
- add `FormDescription` component - include `src` in tsconfig
@ahmedmayara Hi 👋 Feel free to work on this PR, if you have time! if you have a better implementation let me know 🙌 |
Sure I'll check it out, I didn't have time to work on it recently. |
fix vee-validate initialValues on components with `componentField` slotProp
update pnpm and some deps -_-
Just followed the same structure as Shadcn source
|
That's the first time I'm seeing this.. could you create a minimal repro and a ticket in radix-vue. I can get to it asap |
Hard to repro can you switch to this branch? 🙏 |
Problems:
https://github.com/radix-vue/radix-vue/blob/aacb3a29c266988529820ed4b138e2dffc3b510a/packages/radix-vue/src/shared/useEmitAsProps.ts#L5 |
Ahh that's brilliant!! I never thought of exposing useful utilities from And yeah.. using class as props for components is not a good design.. we can create a ticket that replaces all the class props in |
@sadeghbarati Both of the ticket above had merged and released in |
- add new-york style - off eslint import/first rule - use `useId` from radix-vue
@zernonia @ahmedmayara please review it 🙌 <FormField v-slot="{ value }" name="language">
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 😁
Okay 😄 let's wait for |
Nicelt done @sadeghbarati ! Sorry missed out this ticket few days ago 😂 |
Ok will do 🫡 What about mentioning some differences of vee-validate
Since my English is bad I may need help on form.md 🫠 |
- change TabPreview.vue to showcase way of using vee-validate
… and `textarea` form and some other exmaples
The PR looks freaking good @sadeghbarati !!! The docs for |
Use existing VeeValidate components like
Form
,Field
(FormField) andErrorMessage
(FormMessage)Other components are inspired by Shadcn