Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Remove content-type dependency #211

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Remove content-type dependency #211

merged 4 commits into from
Dec 14, 2023

Conversation

samhh
Copy link
Member

@samhh samhh commented Dec 8, 2023 •
edited
Loading

Our size-limit action is broken, but I see this locally:

$ git switch master
$ yarn install
$ yarn run build
$ yarn run size
 dist/unsplash-js.cjs.production.min.js
  Size limit: 5 KB
  Size:       4.21 KB with all dependencies, minified and gzipped

 dist/unsplash-js.esm.js
  Size limit: 5 KB
  Size:       4.22 KB with all dependencies, minified and gzipped

$ git switch content-type
$ yarn install
$ yarn run build
$ yarn run size
 dist/unsplash-js.cjs.production.min.js
  Size limit: 5 KB
  Size:       3.51 KB with all dependencies, minified and gzipped

 dist/unsplash-js.esm.js
  Size limit: 5 KB
  Size:       3.54 KB with all dependencies, minified and gzipped

@samhh
Inline
837f95b
@samhh
Suppress faulty lint
61850ad 
It doesn't understand TypeScript overloads.
@samhh
Test content-type header without lib
ade0d60 
The content-type lib is unnecessary CJS bloat.
@samhh
Remove content-type dep
8606f32
@samhh samhh marked this pull request as ready for review December 8, 2023 10:56
@samhh samhh requested a review from a team as a code owner December 8, 2023 10:56
@samhh samhh requested a review from alexcaza December 8, 2023 10:56
@samhh samhh merged commit 93e8d35 into master Dec 14, 2023
9 checks passed
@samhh samhh deleted the rm-content-type branch December 14, 2023 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexcaza alexcaza alexcaza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samhh @alexcaza