Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup yamllint and local render #139

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Setup yamllint and local render #139

merged 3 commits into from
Jan 5, 2024

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Jan 4, 2024

Description of your changes

  • config
  • make target
  • github action
  • render target
  • Reliable Configuration readiness in test run

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

make render
crossplane beta render examples/cluster-claim.yaml apis/cluster/composition.yaml examples/functions.yaml -r
---
apiVersion: aws.platformref.upbound.io/v1alpha1
kind: Cluster
metadata:
  name: platform-ref-aws
---
apiVersion: apiextensions.crossplane.io/v1alpha1
kind: Usage
metadata:

before yaml fixes

make yamllint
18:45:35 [ .. ] running yamllint
./apis/cluster/composition.yaml
  104:13    error    wrong indentation: expected 14 but found 12  (indentation)

18:45:36 [FAIL]
make: *** [Makefile:80: yamllint] Error 1

@ytsarev
Copy link
Member Author

ytsarev commented Jan 4, 2024

/test-examples

@ytsarev
Copy link
Member Author

ytsarev commented Jan 4, 2024

/test-examples

* config
* make target
* github action
* render target

Signed-off-by: Yury Tsarev <yury@upbound.io>
Signed-off-by: Yury Tsarev <yury@upbound.io>
To avoid e2e test proceeding with the broken
Configuration/ConfigurationRevision state

Signed-off-by: Yury Tsarev <yury@upbound.io>
@haarchri
Copy link
Member

haarchri commented Jan 5, 2024

/test-examples

@haarchri haarchri merged commit e5d1555 into upbound:main Jan 5, 2024
3 checks passed
@ytsarev ytsarev deleted the yamllint branch January 5, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants