Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature:(issue_1215) Allow calling commands by shorthand #1635

Merged
merged 5 commits into from
Jan 9, 2023

Conversation

dearchap
Copy link
Contributor

What type of PR is this?

(REQUIRED)

  • feature

What this PR does / why we need it:

(REQUIRED)

Allows closest match calling of command

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #1215

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Release Notes

(REQUIRED)


Copy link
Member

@meatballhat meatballhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about instead of AllowShorthandCommand going with PrefixMatchCommands?

@dearchap dearchap marked this pull request as ready for review January 6, 2023 14:36
@dearchap dearchap requested a review from a team as a code owner January 6, 2023 14:36
@dearchap
Copy link
Contributor Author

dearchap commented Jan 6, 2023

@meatballhat Renamed

command.go Outdated Show resolved Hide resolved
Copy link
Member

@meatballhat meatballhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

@dearchap dearchap merged commit 2550242 into urfave:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow shorthands by calling commands via a unique name substring
2 participants