Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2584 new block types and permissions for content managers #1057

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Oct 18, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2584

Description

  1. Create new Contact Identifier block type
  2. Create new Partnership block type
  3. Update permissions for content managers

Deployment and testing

Post-deploy steps

  1. lando retune

QA/Testing instructions

  1. Log in as a site admin and create new Contact Identifier and Partnership blocks http://vote-gov.lndo.site/block/add
  2. Log out then Log in as a Content Manager
  3. Make sure you can visit http://vote-gov.lndo.site/es/admin/config/regional/translate
  4. Visit http://vote-gov.lndo.site/block/add and make sure you cannot create a new Contact Identifier or Partnership block
  5. Visit http://vote-gov.lndo.site/admin/content/block and make sure you can edit the Contact Identifier and Partnership block

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada force-pushed the feature/VOTE-2584-new-blocks branch from b3a289c to b40d92d Compare October 18, 2024 22:54
@rayestrada rayestrada force-pushed the feature/VOTE-2584-new-blocks branch from b40d92d to 0ce25c5 Compare October 18, 2024 22:55
@rayestrada rayestrada marked this pull request as ready for review October 18, 2024 22:59
@rayestrada rayestrada requested a review from clmedders October 18, 2024 22:59
Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Was able to make the 2 new blocks as an admin and verify the content manager access to those blocks as well.

@clmedders clmedders merged commit 3795bd3 into dev Oct 21, 2024
2 checks passed
@clmedders clmedders deleted the feature/VOTE-2584-new-blocks branch October 21, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants