Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-3014 Update NVRF to latest and update entry file names #1063

Merged
merged 2 commits into from
Oct 22, 2024
Merged

VOTE-3014 Update NVRF to latest and update entry file names #1063

merged 2 commits into from
Oct 22, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Oct 22, 2024 •
edited
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-3014

Description

Update NVRF to v0.19.0

Deployment and testing

Post-deploy steps

  1. cd into vote_nvrf and run npm i
  2. run lando drush cr

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/register/arizona/mail-in-form-filler and confirm the NVRF app works and generates a filled PDF
  2. visit http://vote-gov.lndo.site/es/registrar/arizona/llenador-de-formulario-por-correo-postal and confirm it works in spanish as well

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada marked this pull request as ready for review October 22, 2024 15:24
@SamiraMSadat SamiraMSadat merged commit 40f3e86 into dev Oct 22, 2024
2 checks passed
@rayestrada rayestrada deleted the feature/VOTE-3014-nvrf-update branch December 3, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamiraMSadat SamiraMSadat SamiraMSadat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayestrada @SamiraMSadat