Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote-3986: Update to hero label #1097

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Vote-3986: Update to hero label #1097

merged 1 commit into from
Nov 7, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Nov 7, 2024 •
edited
Loading

Jira ticket

Vote-3986

Description

Updating label for hero section... a new field name was not created just updating the label for the CMS user to view.

Deployment and testing

Post-deploy steps

  1. run lando retune

QA/Testing instructions

  1. Edit the home page and edit the hero section and verify that the new label for hero background color is now Hero Style

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@SamiraMSadat SamiraMSadat merged commit 4153438 into dev Nov 7, 2024
2 checks passed
@rayestrada rayestrada deleted the feature/vote-3086-hero-label-update branch December 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamiraMSadat SamiraMSadat SamiraMSadat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clmedders @SamiraMSadat