Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote-3101: Hiding non-translatable fields in block types #1145

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Vote-3101: Hiding non-translatable fields in block types #1145

merged 1 commit into from
Dec 2, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Dec 2, 2024 •
edited
Loading

Jira ticket

Vote-3101

Description

Enabled Hide non translatable fields for block types.

Deployment and testing

Post-deploy steps

1 run lando retune

QA/Testing instructions

  1. Create a test block type for the following blocks and verify that when translated those fields are not available to the edited
  • Basic block - classes
  • ab message - message id and touch points id
  • Partnership - each logo
  • Form selector - form link
  • Site alert - alert type
  • State display - date

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review December 2, 2024 02:54
@SamiraMSadat SamiraMSadat merged commit c2516d0 into dev Dec 2, 2024
2 checks passed
@rayestrada rayestrada deleted the feature/vote-3101-hide-blocks branch December 3, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamiraMSadat SamiraMSadat SamiraMSadat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clmedders @SamiraMSadat