Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2598: Implement hero component to state/basic template #942

Merged
merged 4 commits into from
Aug 30, 2024
Merged

VOTE-2598: Implement hero component to state/basic template #942

merged 4 commits into from
Aug 30, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented Aug 27, 2024 •
edited by rayestrada
Loading

Jira ticket

VOTE-2598

Description

Implements in the new hero component to the template for state and basic pages.

Deployment and testing

QA/Testing instructions

  1. navigate to a state page
  2. if there is no image on the page edit page and upload an image
  3. confirm hero shows correct page title, breadcrumbs, and image
  4. navigate to a basic page and repeat steps

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal requested a review from rayestrada August 27, 2024 15:14
@rayestrada rayestrada merged commit 2ca1ee9 into dev Aug 30, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2598/state-hero branch September 25, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayestrada rayestrada rayestrada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlloydbixal @rayestrada