Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2112 Add data attribute to NVRF button #943

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Aug 27, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2112

Description

Add a custom attribute for GA data to button component
Add data-state-ext attribute to the NVRF button

Deployment and testing

Post-deploy steps

  1. lando retune

QA/Testing instructions

  1. Add the NVRF button content in the NVRF selector block
  2. View the source code and confirm the NVRF button has the data-state-ext attribute set to "nvrf-pdf-tool-registration"

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@SamiraMSadat SamiraMSadat changed the title Feature/vote 2112/data attribute nvrf button VOTE-2112 Add data attribute to NVRF button Aug 27, 2024
@mlloydbixal mlloydbixal self-requested a review August 29, 2024 13:12
@mlloydbixal mlloydbixal merged commit a14f42e into dev Aug 29, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2112/data-attribute-nvrf-button branch September 25, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants