Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-1124: Responsive Module Set Up #949

Merged
merged 15 commits into from
Aug 30, 2024
Merged

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Aug 29, 2024

Jira ticket

Vote-1124

Description

This Pr adds and configures the responsive image module from drupal. This will address a lighthouse error that was flagged and will help set up better performance for future images as well

Deployment and testing

Post-deploy steps

  1. run lando retune and cd into the votegov theme and run npm run build

QA/Testing instructions

  1. log in as an admin and add an image to the hero of the home page... verify that there are no major visual regressions on various breakpoints
  2. open up console and run google light house on mobile and verify that the error Properly size images is no longer getting flagged

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review August 30, 2024 09:58
@clmedders clmedders requested a review from rayestrada August 30, 2024 10:22
@rayestrada
Copy link
Contributor

@clmedders take a look at the last few commits I made. Reach out to me with questions about the changes.

@rayestrada rayestrada merged commit a30bc48 into dev Aug 30, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/responsive-img-setup branch September 25, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants