Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-2123: Verify Language options are active #970

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Sep 9, 2024

Jira ticket

Vote-2123

Description

Adding test to check the language options and verify that the expected options are active and have not been removed.

Goal of test: This test will reference the current list of active translations by targeting the data-lang attribute and checking the list that is on the site compared to the json file that is saved

Deployment and testing

Post-deploy steps

n/a

QA/Testing instructions

  1. log in as an admin and visit /es/node/91/edit and unpublished this translation
  2. go to your terminal and cd into testing and run npm run cy:open and select the language-selector.cy.js test and verify that it is failing
  3. go back to the admin page and republish the spanish translation and rerun the test.. it should now be passing

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review September 9, 2024 20:08
@SamiraMSadat SamiraMSadat merged commit 314e9b3 into dev Sep 9, 2024
3 checks passed
tt-gsa pushed a commit that referenced this pull request Sep 10, 2024
* VOTE-2534: Revert upkeep sync file change (#955)

* Vote-2747: update cypress and php version in circleci (#944)

* VOTE-2588: add id to feature card component heading (#958)

* VOTE-2777 add alternate route for Spanish NVRF (#951)

* VOTE-2777 add alternate route for Spanish NVRF

* VOTE-2777 override language switcher for custom route

* phplint fixes

* VOTE-2777 make sure back link recognized language

* VOTE-2777 simplify the form display for the NVRF block

* VOTE-2604: Update drupal core and modules. (#956)

* VOTE-2791 add view revision permissions to content manager and content editor (#959)

* Vote-2655: French Updated Strings (#961)

* VOTE-2275: Enable and configure stage file proxy (#964)

* VOTE-2797 Make the field NVRF PDF pages translatable (#967)

* VOTE-2764: Implement loading animation on NVRF page for slow page load (#963)

* VOTE-2646: Update Arabic Strings (#965)

* VOTE-2802 NVRF updates (#968)

* VOTE-2802 update NVRF to v0.17.0

* VOTE-2802 Remove language selector from nvrf page routes

* VOTE-2802 update path for Spanish NVRF route

* bugfix NVRF svg styling

* Vote-2123: Verify Language options are active (#970)

* Vote-2123: Verify Language optionsq are active

* remove .only flag

---------

Co-authored-by: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Co-authored-by: Mandy Lloyd <amanda.lloyd@gsa.gov>
Co-authored-by: Ray Estrada <raymond.estrada@gsa.gov>
Co-authored-by: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
@rayestrada rayestrada deleted the qa/vote-2123-verify-lang branch September 25, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants