Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-1987: Add custom module to block site_builders on production. #975

Merged
merged 7 commits into from
Sep 13, 2024

Conversation

daniel-crowder
Copy link
Contributor

@daniel-crowder daniel-crowder commented Sep 11, 2024

Jira ticket

VOTE-1987

Description

Add custom module to block users who have the site_builder role on production.

Deployment and testing

Post-deploy steps

n/a

QA/Testing instructions

  1. Locally enable the Vote Users module.
  2. Login as an admin and go to the people admin page.
  3. Confirm that users who have the Site Builder role all have a Blocked status.
  4. To test a login attempt you can look up the uid of a site builder user and run 'lando drush uli uid={uid}'.
  5. Confirm that the response is " Account user.name is blocked and thus cannot login. The user:unblock command may be helpful. "
  6. Disable the Vote Users module.
  7. Confirm that users who have the Site Builder role all have a Active status.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

Copy link
Contributor

@rayestrada rayestrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic!

@rayestrada rayestrada merged commit d8594ed into dev Sep 13, 2024
2 of 3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-1987-block-user-module branch September 25, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants