Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility of lane_number: time to deprecate? #153

Closed
j-d-b opened this issue Jan 21, 2021 · 3 comments · Fixed by #175
Closed

Utility of lane_number: time to deprecate? #153

j-d-b opened this issue Jan 21, 2021 · 3 comments · Fixed by #175
Assignees

Comments

@j-d-b
Copy link
Collaborator

j-d-b commented Jan 21, 2021

The optional lane_number property on the Lane object was left in the major v3.0 release as there were reservations about giving a lane with a not typically driveable lane type (e.g. shoulder or sidewalk) a number. For clarity and to remove connection to what individuals think of when they see "lane number", the required lane order property was added. order is used as an index to identify the lanes positions (order) relative to each other. For many contributors/producers, this was the utility of lane_number, so with order, lane_number has no value. I support that conclusion and think that lane_number remaining in the spec just adds confusion.

In summary, it is not clear that there is any utility in lane_number.

If there are any producers or consumers who see value in lane_number aside from identifying the lane's position, please raise your opinions!

If there is no value, the next step is to deprecate lane_number.

@j-d-b j-d-b added Needs discussion This issue needs clarification/additional discussion or is inactive Data-content labels Jan 21, 2021
@j-d-b
Copy link
Collaborator Author

j-d-b commented Apr 14, 2021

Every time I present the spec, I always gloss over lane_number as for new adopters it adds confusion rather than value.

Seeing again no new comments here, I'll move forward with the PR.

@natedeshmukhtowery
Copy link
Collaborator

Thumbs up.

@j-d-b j-d-b self-assigned this Jun 24, 2021
@j-d-b j-d-b removed the Needs discussion This issue needs clarification/additional discussion or is inactive label Jun 24, 2021
@j-d-b j-d-b linked a pull request Jul 9, 2021 that will close this issue
@j-d-b
Copy link
Collaborator Author

j-d-b commented Dec 16, 2021

Completed in #175.

@j-d-b j-d-b closed this as completed Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants