-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable road restriction feeds #205
Merged
j-d-b
merged 64 commits into
usdot-jpo-ode:v4.0-release
from
DeraldDudley:RestrictionEvent
Dec 13, 2021
Merged
Enable road restriction feeds #205
j-d-b
merged 64 commits into
usdot-jpo-ode:v4.0-release
from
DeraldDudley:RestrictionEvent
Dec 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-d-b
added
the
Specification Extension
This issue/PR is related to the Specification Extension Subgroup
label
Sep 21, 2021
Bring in refactored RoadEvent from main WZDx repository
j-d-b
reviewed
Nov 1, 2021
j-d-b
changed the title
Create RestrictionEvent Object
Add RestrictionRoadEvent and new RoadRestrictionFeed
Nov 1, 2021
j-d-b
added
New Functionality
This item relates to adding new functionality to the specification
v4.0
labels
Nov 1, 2021
j-d-b
changed the title
Add RestrictionRoadEvent and new RoadRestrictionFeed
Add RestrictionRoadEvent and RoadRestrictionFeed
Nov 1, 2021
j-d-b
reviewed
Dec 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a bit of trouble with the schema but got it working. This PR looks good to me now, ready for review.
mark-mockett
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks Jacob and Derald!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
New Functionality
This item relates to adding new functionality to the specification
Specification Extension
This issue/PR is related to the Specification Extension Subgroup
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable road restriction feeds; add RestrictionRoadEvent and RoadRestrictionFeed
Contingent on Pull Request #209 and #198.
The RestrictionRoadEvent enables the publication of road restriction feeds (see RoadRestrictionFeed). Restriction feeds inform drivers of hazardous restrictions such as low clearances, narrow widths, weight limits, and more.
New Objects
RestrictionRoadEvent Object
The
RestrictionRoadEvent
object describes one or more restrictions on a section of a roadway. It describes the location of the road section and the limitations on how it can be used. TheRestrictionRoadEvent
is a linear road event intended to represent persistent restrictions without a defined start or event date, such as bridge clearances.The
RestrictionRoadEvent
is a type of road event; it has acore_details
property which contains the RoadEventCoreDetails and exists within a RoadEventFeature.For representing restrictions due to road work, see the WorkZoneRoadEvent and WZDxFeed.
Properties
core_details
restrictions
lanes
property is not provided.lanes
restrictions
property is not provided.Used By
properties
WZDx Feeds
WZDxFeed
(existing)WZDxFeed
is the original work zone data exchange feed, focused on describing high-level information about road work.SwzDeviceFeed
(see #208)WZDxFeed
. Third-parties such as mapping companies and CAVs may also be interested in field device information.RoadRestrictionFeed
(new)Notes about this PR
This PR is a draft as it cannot be implemented unless #209 and #198 are approved. It contains a JSON schema for the new RoadRestrictionFeed and fully complete markdown documentation for the new objects, but does not update example files nor the object diagram. It targets the source branch of #209 (
usdot-jpo-ode:refactor-road-event
). The source branch for #198 (DeraldDudley:v4.0-release-restrictions
) is merged into the source branch here (DeraldDudley:RestrictionEvent
), so some of the changes proposed here are from the restriction change. Thus the files changed shows more than just the "new" changes for the RoadRestrictionfeed and RestrictionRoadEvent.@j-d-b edit: updated to match the finalized implementation.