Fix storage deposit limit encoding #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
changed the title
ascjones
commented
Sep 23, 2022
| @@ -100,26 +100,27 @@ impl DisplayEvents { | |||
|
|
|||
| let event_data = &mut event.field_bytes(); | |||
| let mut unnamed_field_name = 0; | |||
| for (field, field_ty) in event_fields { | |||
| for field in event_fields { | |||
There was a problem hiding this comment.
Note that changes here are only to fix compilation because of the updating to subxt 0.24, and unrelated to the bugfix itself.
HCastano
approved these changes
Sep 23, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in the
subxtcodegen meant that compact types as type parameters were not generated correctly.storage_deposit_limitis anOption<Compact<u128>>but was generated as aOption<u128>which resulted in incorrect encoding. paritytech/subxt#651 fixes that issue and this PR uses the newsubxtrelease and fixes the issue here.Fixes #734