From 6faa27a9b10e9d57b816ba9346920ec09fd1c171 Mon Sep 17 00:00:00 2001 From: lohxt1 Date: Tue, 4 Jun 2024 12:18:31 +0530 Subject: [PATCH] fix tests for bruno-electron & bruno-lang --- .../src/ipc/network/interpolate-vars.js | 2 +- packages/bruno-lang/v2/tests/fixtures/request.bru | 8 ++++++-- packages/bruno-lang/v2/tests/fixtures/request.json | 13 +++++++++++-- 3 files changed, 18 insertions(+), 5 deletions(-) diff --git a/packages/bruno-electron/src/ipc/network/interpolate-vars.js b/packages/bruno-electron/src/ipc/network/interpolate-vars.js index b544ed7d10..5792b58e43 100644 --- a/packages/bruno-electron/src/ipc/network/interpolate-vars.js +++ b/packages/bruno-electron/src/ipc/network/interpolate-vars.js @@ -86,7 +86,7 @@ const interpolateVars = (request, envVars = {}, collectionVariables = {}, proces param.value = _interpolate(param.value); }); - if (request.params.length) { + if (request?.params?.length) { let url = request.url; if (!url.startsWith('http://') && !url.startsWith('https://')) { diff --git a/packages/bruno-lang/v2/tests/fixtures/request.bru b/packages/bruno-lang/v2/tests/fixtures/request.bru index fcfe7b8183..5a7065c24a 100644 --- a/packages/bruno-lang/v2/tests/fixtures/request.bru +++ b/packages/bruno-lang/v2/tests/fixtures/request.bru @@ -5,17 +5,21 @@ meta { } get { - url: https://api.textlocal.in/send + url: https://api.textlocal.in/send/:id body: json auth: bearer } -query { +params:query { apiKey: secret numbers: 998877665 ~message: hello } +params:path { + id: 123 +} + headers { content-type: application/json Authorization: Bearer 123 diff --git a/packages/bruno-lang/v2/tests/fixtures/request.json b/packages/bruno-lang/v2/tests/fixtures/request.json index afb7ca3f90..72c019c483 100644 --- a/packages/bruno-lang/v2/tests/fixtures/request.json +++ b/packages/bruno-lang/v2/tests/fixtures/request.json @@ -6,25 +6,34 @@ }, "http": { "method": "get", - "url": "https://api.textlocal.in/send", + "url": "https://api.textlocal.in/send/:id", "body": "json", "auth": "bearer" }, - "query": [ + "params": [ { "name": "apiKey", "value": "secret", + "type": "query", "enabled": true }, { "name": "numbers", "value": "998877665", + "type": "query", "enabled": true }, { "name": "message", "value": "hello", + "type": "query", "enabled": false + }, + { + "name": "id", + "value": "123", + "type": "path", + "enabled": true } ], "headers": [