From 51f289359bd11a72ba35cdfaee5ec053aeb21ec1 Mon Sep 17 00:00:00 2001 From: Amos Folz Date: Mon, 1 Apr 2019 00:25:54 +0000 Subject: [PATCH 01/16] Replace FA4 with FA5. Replace aliased icons (aliasing is deprecated in FA5) Apply fix to AdminLTE to work with FA5 --- .../templates/navigation/sidebar-menu.html.twig | 6 +++--- .../templates/pages/abstract/dashboard.html.twig | 2 +- .../admin/templates/pages/dashboard.html.twig | 2 +- app/sprinkles/admin/templates/pages/role.html.twig | 2 +- app/sprinkles/admin/templates/pages/roles.html.twig | 2 +- app/sprinkles/admin/templates/pages/user.html.twig | 4 ++-- .../admin/templates/tables/users.html.twig | 2 +- app/sprinkles/core/asset-bundles.json | 2 +- .../core/assets/userfrosting/css/AdminLTE.css | 3 ++- app/sprinkles/core/package.json | 13 ++++++------- 10 files changed, 19 insertions(+), 19 deletions(-) diff --git a/app/sprinkles/admin/templates/navigation/sidebar-menu.html.twig b/app/sprinkles/admin/templates/navigation/sidebar-menu.html.twig index e6d4a7cc1..a579ec4d6 100644 --- a/app/sprinkles/admin/templates/navigation/sidebar-menu.html.twig +++ b/app/sprinkles/admin/templates/navigation/sidebar-menu.html.twig @@ -1,7 +1,7 @@ {% block navigation %} {% if checkAccess('uri_dashboard') %}
  • - {{ translate("DASHBOARD") }} + {{ translate("DASHBOARD") }}
  • {% endif %} {% if checkAccess('uri_users') %} @@ -22,7 +22,7 @@ {% endif %} {% if checkAccess('uri_roles') %}
  • - {{ translate("ROLE", 2) }} + {{ translate("ROLE", 2) }}
  • {% endif %} {% if checkAccess('uri_permissions') %} @@ -35,4 +35,4 @@ {{ translate("GROUP", 2) }} {% endif %} -{% endblock %} \ No newline at end of file +{% endblock %} diff --git a/app/sprinkles/admin/templates/pages/abstract/dashboard.html.twig b/app/sprinkles/admin/templates/pages/abstract/dashboard.html.twig index 2a53de456..3188a348a 100644 --- a/app/sprinkles/admin/templates/pages/abstract/dashboard.html.twig +++ b/app/sprinkles/admin/templates/pages/abstract/dashboard.html.twig @@ -84,4 +84,4 @@ {% block scripts_page_group %} {{ assets.js('js/admin') | raw }} -{% endblock %} \ No newline at end of file +{% endblock %} diff --git a/app/sprinkles/admin/templates/pages/dashboard.html.twig b/app/sprinkles/admin/templates/pages/dashboard.html.twig index f9c85a34b..630b23e25 100644 --- a/app/sprinkles/admin/templates/pages/dashboard.html.twig +++ b/app/sprinkles/admin/templates/pages/dashboard.html.twig @@ -26,7 +26,7 @@
    - +
    {{ translate("ROLE", 2) }} {{counter.roles}} diff --git a/app/sprinkles/admin/templates/pages/role.html.twig b/app/sprinkles/admin/templates/pages/role.html.twig index fa8983814..aa79cf5b6 100644 --- a/app/sprinkles/admin/templates/pages/role.html.twig +++ b/app/sprinkles/admin/templates/pages/role.html.twig @@ -51,7 +51,7 @@
    - +

    {{role.name}}

    diff --git a/app/sprinkles/admin/templates/pages/roles.html.twig b/app/sprinkles/admin/templates/pages/roles.html.twig index c5b399556..c8ff090c0 100644 --- a/app/sprinkles/admin/templates/pages/roles.html.twig +++ b/app/sprinkles/admin/templates/pages/roles.html.twig @@ -15,7 +15,7 @@
    -

    {{translate('ROLE', 2)}}

    +

    {{translate('ROLE', 2)}}

    {% include "tables/table-tool-menu.html.twig" %}
    diff --git a/app/sprinkles/admin/templates/pages/user.html.twig b/app/sprinkles/admin/templates/pages/user.html.twig index 16522084a..de6bcbf6f 100644 --- a/app/sprinkles/admin/templates/pages/user.html.twig +++ b/app/sprinkles/admin/templates/pages/user.html.twig @@ -43,7 +43,7 @@ {% if 'roles' not in tools.hidden %}
  • - {{translate('ROLE', 2)}} + {{translate('ROLE', 2)}}
  • {% endif %} @@ -117,7 +117,7 @@ {% if 'roles' not in fields.hidden %}
    - {{translate("ROLE", 2)}} + {{translate("ROLE", 2)}}

    {% for role in user.roles %} {{role.name}} diff --git a/app/sprinkles/admin/templates/tables/users.html.twig b/app/sprinkles/admin/templates/tables/users.html.twig index 1cebb47e2..cf1ae228a 100644 --- a/app/sprinkles/admin/templates/tables/users.html.twig +++ b/app/sprinkles/admin/templates/tables/users.html.twig @@ -109,7 +109,7 @@

  • - {% endverbatim %}{{translate("ROLE.MANAGE")}}{% verbatim %} + {% endverbatim %}{{translate("ROLE.MANAGE")}}{% verbatim %}
  • diff --git a/app/sprinkles/core/asset-bundles.json b/app/sprinkles/core/asset-bundles.json index 5dfeac792..02b28b1e3 100644 --- a/app/sprinkles/core/asset-bundles.json +++ b/app/sprinkles/core/asset-bundles.json @@ -45,7 +45,7 @@ }, "css/main": { "styles": [ - "vendor/font-awesome/css/font-awesome.css", + "vendor/@fortawesome/fontawesome-free/css/all.css", "vendor/bootstrap/dist/css/bootstrap.css", "vendor/select2/dist/css/select2.css", "vendor/icheck/skins/square/_all.css", diff --git a/app/sprinkles/core/assets/userfrosting/css/AdminLTE.css b/app/sprinkles/core/assets/userfrosting/css/AdminLTE.css index 103689d41..9aef04a34 100644 --- a/app/sprinkles/core/assets/userfrosting/css/AdminLTE.css +++ b/app/sprinkles/core/assets/userfrosting/css/AdminLTE.css @@ -255,7 +255,8 @@ a:focus { background-color: transparent; background-image: none; padding: 15px 15px; - font-family: fontAwesome; + font-family: "Font Awesome 5 Free"; + font-weight: 900; } .main-header .sidebar-toggle:before { content: "\f0c9"; diff --git a/app/sprinkles/core/package.json b/app/sprinkles/core/package.json index cb2526ebd..2d629516d 100644 --- a/app/sprinkles/core/package.json +++ b/app/sprinkles/core/package.json @@ -3,19 +3,18 @@ "dependencies": { "bootstrap": "^3.3.6", "clipboard": "^1.5.16", - "font-awesome": "^4.7.0", + "fastclick": "^1.0.6", "handlebars": "^3.0.3", + "icheck": "^1.0.1", + "ionicons": "^2.0.1", "jquery": "^3.2.1", + "jquery-slimscroll": "~1.3.8", "jquery-ui": "^1.12.0", "jquery-validation": "~1.14.0", - "select2": "^4.0.5", - "tablesorter": "^2.28.5", "moment": "^2.17.1", + "select2": "^4.0.5", "speakingurl": "^11.0.0", - "icheck": "^1.0.1", - "jquery-slimscroll": "~1.3.8", - "fastclick": "^1.0.6", - "ionicons": "^2.0.1", + "tablesorter": "^2.28.5", "urijs": "^1.18.4" } } From 0a9e12e20116c32cc8456286a2f46d20f8ecb76f Mon Sep 17 00:00:00 2001 From: Amos Folz Date: Mon, 1 Apr 2019 00:45:55 +0000 Subject: [PATCH 02/16] Update FA5 icon prefix 'fa' to 'fas' to align with new conventions --- .../Database/Migrations/v400/GroupsTable.php | 2 +- .../forms/settings-account.html.twig | 2 +- .../forms/settings-profile.html.twig | 2 +- .../templates/navigation/user-card.html.twig | 2 +- .../pages/error/compromised.html.twig | 2 +- .../admin/src/Controller/GroupController.php | 2 +- .../admin/templates/forms/group.html.twig | 4 +-- .../admin/templates/forms/role.html.twig | 4 +-- .../admin/templates/forms/user.html.twig | 16 ++++----- .../modals/role-manage-permissions.html.twig | 2 +- .../modals/user-manage-roles.html.twig | 2 +- .../modals/user-set-password.html.twig | 4 +-- .../navigation/sidebar-menu.html.twig | 12 +++---- .../pages/abstract/dashboard.html.twig | 2 +- .../templates/pages/activities.html.twig | 2 +- .../admin/templates/pages/dashboard.html.twig | 16 ++++----- .../admin/templates/pages/group.html.twig | 10 +++--- .../admin/templates/pages/groups.html.twig | 4 +-- .../templates/pages/permission.html.twig | 6 ++-- .../templates/pages/permissions.html.twig | 2 +- .../admin/templates/pages/role.html.twig | 16 ++++----- .../admin/templates/pages/roles.html.twig | 4 +-- .../admin/templates/pages/user.html.twig | 32 ++++++++--------- .../admin/templates/pages/users.html.twig | 4 +-- .../templates/tables/activities.html.twig | 8 ++--- .../admin/templates/tables/groups.html.twig | 8 ++--- .../templates/tables/permissions.html.twig | 4 +-- .../admin/templates/tables/roles.html.twig | 10 +++--- .../admin/templates/tables/users.html.twig | 22 ++++++------ .../core/assets/userfrosting/css/AdminLTE.css | 12 +++---- .../assets/userfrosting/css/userfrosting.css | 2 +- .../core/assets/userfrosting/js/AdminLTE.js | 2 +- .../core/assets/userfrosting/js/uf-form.js | 2 +- .../js/uf-jqueryvalidation-config.js | 2 +- .../core/assets/userfrosting/js/uf-table.js | 14 ++++---- .../core/src/Util/CheckEnvironment.php | 26 +++++++------- .../templates/navigation/breadcrumb.html.twig | 2 +- .../templates/navigation/main-nav.html.twig | 2 +- .../core/templates/pages/about.html.twig | 36 +++++++++---------- .../templates/pages/abstract/error.html.twig | 4 +-- .../core/templates/pages/error/400.html.twig | 2 +- .../core/templates/pages/error/404.html.twig | 2 +- .../pages/error/config-errors.html.twig | 2 +- .../core/templates/pages/index.html.twig | 10 +++--- .../templates/pages/partials/alerts.html.twig | 2 +- .../tables/table-paginated.html.twig | 12 +++---- .../tables/table-tool-menu.html.twig | 4 +-- 47 files changed, 172 insertions(+), 172 deletions(-) diff --git a/app/sprinkles/account/src/Database/Migrations/v400/GroupsTable.php b/app/sprinkles/account/src/Database/Migrations/v400/GroupsTable.php index 937aa67c8..429bbb0b4 100644 --- a/app/sprinkles/account/src/Database/Migrations/v400/GroupsTable.php +++ b/app/sprinkles/account/src/Database/Migrations/v400/GroupsTable.php @@ -34,7 +34,7 @@ public function up() $table->string('slug'); $table->string('name'); $table->text('description')->nullable(); - $table->string('icon', 100)->nullable(false)->default('fa fa-user')->comment('The icon representing users in this group.'); + $table->string('icon', 100)->nullable(false)->default('fas fa-user')->comment('The icon representing users in this group.'); $table->timestamps(); $table->engine = 'InnoDB'; diff --git a/app/sprinkles/account/templates/forms/settings-account.html.twig b/app/sprinkles/account/templates/forms/settings-account.html.twig index 996b27b57..66393c783 100644 --- a/app/sprinkles/account/templates/forms/settings-account.html.twig +++ b/app/sprinkles/account/templates/forms/settings-account.html.twig @@ -1,6 +1,6 @@
    -

    {{translate("ACCOUNT.SETTINGS")}}

    +

    {{translate("ACCOUNT.SETTINGS")}}

    {% include "forms/csrf.html.twig" %} diff --git a/app/sprinkles/account/templates/forms/settings-profile.html.twig b/app/sprinkles/account/templates/forms/settings-profile.html.twig index 0b0a788ab..638469f5b 100644 --- a/app/sprinkles/account/templates/forms/settings-profile.html.twig +++ b/app/sprinkles/account/templates/forms/settings-profile.html.twig @@ -1,6 +1,6 @@
    -

    {{translate("PROFILE.SETTINGS")}}

    +

    {{translate("PROFILE.SETTINGS")}}

    {% include "forms/csrf.html.twig" %} diff --git a/app/sprinkles/account/templates/navigation/user-card.html.twig b/app/sprinkles/account/templates/navigation/user-card.html.twig index 47e18f1cd..ec8a2e46b 100644 --- a/app/sprinkles/account/templates/navigation/user-card.html.twig +++ b/app/sprinkles/account/templates/navigation/user-card.html.twig @@ -4,7 +4,7 @@ User Image - + {% endblock %}