Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW CONTENT comment in metaschemas #1176

Closed
guyzyl opened this issue Mar 15, 2022 · 1 comment · Fixed by #1179
Closed

NEW CONTENT comment in metaschemas #1176

guyzyl opened this issue Mar 15, 2022 · 1 comment · Fixed by #1179
Assignees
@guyzyl
Labels
question
Milestone
OSCAL 1.0.2

Comments

@guyzyl
Copy link
Contributor

guyzyl commented Mar 15, 2022

I came across the following block comment in the oscal_assessment-comment_metaschema.xml file:

   <!-- ===============================  -->
   <!-- ========= NEW CONTENT =========  -->
   <!-- ===============================  -->

From a quick search, it exists in a few other metaschemas.

Can it be removed it? (I'll open a PR if the answer is yes)
Its purpose isn't clear (not to me at least) and isn't explained in the commit message.
@aj-stein-nist
Copy link
Contributor

Consider yourself assigned! :-)

Feel free to draft a PR.

@aj-stein-nist aj-stein-nist added this to the OSCAL 1.0.3 milestone Mar 15, 2022
guyzyl added a commit to guyzyl/OSCAL that referenced this issue Mar 16, 2022
@guyzyl
Remove NEW CONTENT comment blocks
8911a48 
Also removed the related blocks:
- `END NEW CONTENT`
- `NEW`
- `END NEW`

This fixes usnistgov#1176
@guyzyl guyzyl mentioned this issue Mar 16, 2022
Merged
5 tasks
@aj-stein-nist aj-stein-nist linked a pull request Mar 16, 2022 that will close this issue
Remove NEW CONTENT comment blocks #1179
Merged
5 tasks
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this issue Mar 18, 2022
@guyzyl @aj-stein-nist
Remove NEW CONTENT comment blocks
9969f25 
Also removed the related blocks:
- `END NEW CONTENT`
- `NEW`
- `END NEW`

This fixes usnistgov#1176
david-waltermire pushed a commit to guyzyl/OSCAL that referenced this issue Mar 18, 2022
@guyzyl @david-waltermire
Remove NEW CONTENT comment blocks
f87ba3e 
Also removed the related blocks:
- `END NEW CONTENT`
- `NEW`
- `END NEW`

This fixes usnistgov#1176
aj-stein-nist pushed a commit that referenced this issue Mar 18, 2022
@guyzyl
Remove NEW CONTENT comment blocks (#1179)
76339bd 
Also removed the related blocks:
- `END NEW CONTENT`
- `NEW`
- `END NEW`

This fixes #1176
david-waltermire pushed a commit that referenced this issue Mar 18, 2022
@guyzyl @david-waltermire
Remove NEW CONTENT comment blocks (#1179)
8f7189c 
Also removed the related blocks:
- `END NEW CONTENT`
- `NEW`
- `END NEW`

This fixes #1176
iMichaela pushed a commit to iMichaela/OSCAL that referenced this issue Apr 7, 2022
@guyzyl @iMichaela
Remove NEW CONTENT comment blocks (usnistgov#1179)
94bdc28 
Also removed the related blocks:
- `END NEW CONTENT`
- `NEW`
- `END NEW`

This fixes usnistgov#1176
Rene2mt pushed a commit to Rene2mt/OSCAL that referenced this issue May 17, 2022
@guyzyl @Rene2mt
Remove NEW CONTENT comment blocks (usnistgov#1179)
92c5ba4 
Also removed the related blocks:
- `END NEW CONTENT`
- `NEW`
- `END NEW`

This fixes usnistgov#1176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guyzyl guyzyl

Labels
question
Projects
None yet
Milestone
OSCAL 1.0.2
Development

Successfully merging a pull request may close this issue.

Remove NEW CONTENT comment blocks guyzyl/OSCAL
3 participants
@guyzyl @david-waltermire @aj-stein-nist