Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSCAL Develop Branch SimpleType Type XSD Generation Missing #1454

Closed
aj-stein-nist opened this issue Sep 14, 2022 · 1 comment · Fixed by #1455
Closed

OSCAL Develop Branch SimpleType Type XSD Generation Missing #1454

aj-stein-nist opened this issue Sep 14, 2022 · 1 comment · Fixed by #1455
Assignees
@aj-stein-nist
Labels
bug Scope: CI/CD Enhancements to the project's Continuous Integration and Continuous Delivery pipeline.
Milestone
v1.1.0

Comments

@aj-stein-nist
Copy link
Contributor

Describe the bug

In develop branch, CI/CD builds will fail because recent commits that add missing schema definitions for important simple types used by complex types in OSCAL per their Metaschema definitions, for example, DateTimeDatatype as exhibited and reported from user contributions with CIS and their OSCAL catalogs. I found this through testing the CI in my fork. See below.

Example CI/CD complete build logging and the snippet is below:

XML Schema validation failed for 'src/catalogs/xml/cis-controls-v8_OSCAL-1.0.xml' using schema 'xml/schema/oscal_catalog_schema.xsd'.
/home/runner/work/CISControls_OSCAL/CISControls_OSCAL/git-content/OSCAL/xml/schema/oscal_catalog_schema.xsd:2058: element simpleType: Schemas parser error : simple type 'DateTimeWithTimezoneDatatype', attribute 'base': The QName value '{http://csrc.nist.gov/ns/oscal/1.0}DateTimeDatatype' does not resolve to a(n) simple type definition.

Commit usnistgov/metaschema@f28a588 happens before the commit usnistgov/metaschema@1e08f4b that fixes this in the most current metaschema develop. Commit usnistgov/metaschema@f28a588 is the current position in OSCAL's develop branch in 37a3f11.

Who is the bug affecting

OSCAL tool developers using NIST OSCAL Team's CI/CD as a reference and starting point.

What is affected by this bug

CI/CD

How do we replicate this issue

  1. Check oscal-content, CISControls_OSCAL, or any repo using the older submodule at commit missing the relevant XSD type file generated correctly.
  2. Observe build failing and logging generation errors.

Expected behavior (i.e. solution)

The CI/CD successfully copies and converts content.

Other comments

No response
@aj-stein-nist aj-stein-nist added bug Scope: CI/CD Enhancements to the project's Continuous Integration and Continuous Delivery pipeline. labels Sep 14, 2022
@aj-stein-nist aj-stein-nist moved this from Todo to In Progress in NIST OSCAL Work Board Sep 14, 2022
@aj-stein-nist aj-stein-nist changed the title SimpleType Blah Blah in Build OSCAL Develop Branch SimpleType Type XSD Generation Missing Sep 14, 2022
aj-stein-nist added a commit that referenced this issue Sep 14, 2022
@aj-stein-nist
Update metaschema submodule for #1454.
4bb8f72
@aj-stein-nist aj-stein-nist mentioned this issue Sep 14, 2022
Merged
6 tasks
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Sep 14, 2022
@aj-stein-nist
Update obsolete GCN FR OSCAL article link
1ee03d5 
While working on usnistgov#1454, this link appears to have changed
on the GCN news site, so we update. More info in failed build here.

https://github.com/usnistgov/OSCAL/actions/runs/3054991503

Additionaly we formatted it back down to a conventional Markdown link.
Previously it was an inline <a/> with data-proofer-ignore='yes' attribute
and it was/is unclear why that was done. No conclusive evidence found
with git blamen on a call with Dave.

Be forewarned: if you found this commit to understand, you have likely
gone too far.
@aj-stein-nist aj-stein-nist linked a pull request Sep 14, 2022 that will close this issue
Update metaschema submodule for usnistgov/OSCAL#1454. #1455
Merged
6 tasks
@aj-stein-nist aj-stein-nist moved this from In Progress to Under Review in NIST OSCAL Work Board Sep 14, 2022
@aj-stein-nist aj-stein-nist self-assigned this Sep 15, 2022
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Sep 19, 2022
@aj-stein-nist
Update obsolete GCN FR OSCAL article link
32e5919 
While working on usnistgov#1454, this link appears to have changed
on the GCN news site, so we update. More info in failed build here.

https://github.com/usnistgov/OSCAL/actions/runs/3054991503

Additionaly we formatted it back down to a conventional Markdown link.
Previously it was an inline <a/> with data-proofer-ignore='yes' attribute
and it was/is unclear why that was done. No conclusive evidence found
with git blamen on a call with Dave.

Be forewarned: if you found this commit to understand, you have likely
gone too far.
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Sep 19, 2022
@aj-stein-nist
Update metaschema submodule for usnistgov#1454.
8d692ed
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Sep 19, 2022
@aj-stein-nist
Update metaschema submodule for usnistgov#1454.
339f29b
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Sep 19, 2022
@aj-stein-nist
Update obsolete GCN FR OSCAL article link
131941e 
While working on usnistgov#1454, this link appears to have changed
on the GCN news site, so we update. More info in failed build here.

https://github.com/usnistgov/OSCAL/actions/runs/3054991503

Additionaly we formatted it back down to a conventional Markdown link.
Previously it was an inline <a/> with data-proofer-ignore='yes' attribute
and it was/is unclear why that was done. No conclusive evidence found
with git blamen on a call with Dave.

Be forewarned: if you found this commit to understand, you have likely
gone too far.
aj-stein-nist added a commit that referenced this issue Sep 19, 2022
@aj-stein-nist
Update metaschema submodule for #1454. (#1455)
0972890 
* Update metaschema submodule for #1454.

* Update obsolete GCN FR OSCAL article link

While working on #1454, this link appears to have changed
on the GCN news site, so we update. More info in failed build here.

https://github.com/usnistgov/OSCAL/actions/runs/3054991503

Additionaly we formatted it back down to a conventional Markdown link.
Previously it was an inline <a/> with data-proofer-ignore='yes' attribute
and it was/is unclear why that was done. No conclusive evidence found
with git blamen on a call with Dave.

Be forewarned: if you found this commit to understand, you have likely
gone too far.
@aj-stein-nist aj-stein-nist moved this from Under Review to Done in NIST OSCAL Work Board Sep 28, 2022
@aj-stein-nist
Copy link
Contributor Author

I think this can be closed for now. Moving up the submodule was merged and completed earlier this week.

aj-stein-nist added a commit that referenced this issue Oct 18, 2022
@aj-stein-nist
Update metaschema submodule for #1454. (#1455)
0d22a3f 
* Update metaschema submodule for #1454.

* Update obsolete GCN FR OSCAL article link

While working on #1454, this link appears to have changed
on the GCN news site, so we update. More info in failed build here.

https://github.com/usnistgov/OSCAL/actions/runs/3054991503

Additionaly we formatted it back down to a conventional Markdown link.
Previously it was an inline <a/> with data-proofer-ignore='yes' attribute
and it was/is unclear why that was done. No conclusive evidence found
with git blamen on a call with Dave.

Be forewarned: if you found this commit to understand, you have likely
gone too far.
david-waltermire pushed a commit that referenced this issue Oct 31, 2022
@aj-stein-nist @david-waltermire
Update metaschema submodule for #1454. (#1455)
4847e3e 
* Update metaschema submodule for #1454.

* Update obsolete GCN FR OSCAL article link

While working on #1454, this link appears to have changed
on the GCN news site, so we update. More info in failed build here.

https://github.com/usnistgov/OSCAL/actions/runs/3054991503

Additionaly we formatted it back down to a conventional Markdown link.
Previously it was an inline <a/> with data-proofer-ignore='yes' attribute
and it was/is unclear why that was done. No conclusive evidence found
with git blamen on a call with Dave.

Be forewarned: if you found this commit to understand, you have likely
gone too far.
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Jan 10, 2023
@aj-stein-nist
Update metaschema submodule for usnistgov#1454. (usnistgov#1455)
c38aa86 
* Update metaschema submodule for usnistgov#1454.

* Update obsolete GCN FR OSCAL article link

While working on usnistgov#1454, this link appears to have changed
on the GCN news site, so we update. More info in failed build here.

https://github.com/usnistgov/OSCAL/actions/runs/3054991503

Additionaly we formatted it back down to a conventional Markdown link.
Previously it was an inline <a/> with data-proofer-ignore='yes' attribute
and it was/is unclear why that was done. No conclusive evidence found
with git blamen on a call with Dave.

Be forewarned: if you found this commit to understand, you have likely
gone too far.
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Feb 6, 2023
@aj-stein-nist
Update metaschema submodule for usnistgov#1454. (usnistgov#1455)
96af3d5 
* Update metaschema submodule for usnistgov#1454.

* Update obsolete GCN FR OSCAL article link

While working on usnistgov#1454, this link appears to have changed
on the GCN news site, so we update. More info in failed build here.

https://github.com/usnistgov/OSCAL/actions/runs/3054991503

Additionaly we formatted it back down to a conventional Markdown link.
Previously it was an inline <a/> with data-proofer-ignore='yes' attribute
and it was/is unclear why that was done. No conclusive evidence found
with git blamen on a call with Dave.

Be forewarned: if you found this commit to understand, you have likely
gone too far.
aj-stein-nist added a commit to aj-stein-nist/OSCAL that referenced this issue Jun 29, 2023
@aj-stein-nist
Update metaschema submodule for usnistgov/OSCAL#1454. (#1455)
7002706 
* Update metaschema submodule for usnistgov/OSCAL#1454.

* Update obsolete GCN FR OSCAL article link

While working on usnistgov/OSCAL#1454, this link appears to have changed
on the GCN news site, so we update. More info in failed build here.

https://github.com/usnistgov/OSCAL/actions/runs/3054991503

Additionaly we formatted it back down to a conventional Markdown link.
Previously it was an inline <a/> with data-proofer-ignore='yes' attribute
and it was/is unclear why that was done. No conclusive evidence found
with git blamen on a call with Dave.

Be forewarned: if you found this commit to understand, you have likely
gone too far.
aj-stein-nist added a commit to aj-stein-nist/OSCAL that referenced this issue Jun 29, 2023
@aj-stein-nist
Update metaschema submodule for usnistgov/OSCAL#1454. (#1455)
a3cb750 
* Update metaschema submodule for usnistgov/OSCAL#1454.

* Update obsolete GCN FR OSCAL article link

While working on usnistgov/OSCAL#1454, this link appears to have changed
on the GCN news site, so we update. More info in failed build here.

https://github.com/usnistgov/OSCAL/actions/runs/3054991503

Additionaly we formatted it back down to a conventional Markdown link.
Previously it was an inline <a/> with data-proofer-ignore='yes' attribute
and it was/is unclear why that was done. No conclusive evidence found
with git blamen on a call with Dave.

Be forewarned: if you found this commit to understand, you have likely
gone too far.
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Jul 10, 2023
@aj-stein-nist
Update metaschema submodule for usnistgov#1454. (usnistgov#1455)
0ed533b 
* Update metaschema submodule for usnistgov#1454.

* Update obsolete GCN FR OSCAL article link

While working on usnistgov#1454, this link appears to have changed
on the GCN news site, so we update. More info in failed build here.

https://github.com/usnistgov/OSCAL/actions/runs/3054991503

Additionaly we formatted it back down to a conventional Markdown link.
Previously it was an inline <a/> with data-proofer-ignore='yes' attribute
and it was/is unclear why that was done. No conclusive evidence found
with git blamen on a call with Dave.

Be forewarned: if you found this commit to understand, you have likely
gone too far.
@aj-stein-nist aj-stein-nist added this to the v1.1.0 milestone Jul 27, 2023
aj-stein-nist added a commit to galtm/OSCAL that referenced this issue Sep 28, 2023
@aj-stein-nist
Update metaschema submodule for usnistgov#1454. (usnistgov#1455)
957bfa9 
* Update metaschema submodule for usnistgov#1454.

* Update obsolete GCN FR OSCAL article link

While working on usnistgov#1454, this link appears to have changed
on the GCN news site, so we update. More info in failed build here.

https://github.com/usnistgov/OSCAL/actions/runs/3054991503

Additionaly we formatted it back down to a conventional Markdown link.
Previously it was an inline <a/> with data-proofer-ignore='yes' attribute
and it was/is unclear why that was done. No conclusive evidence found
with git blamen on a call with Dave.

Be forewarned: if you found this commit to understand, you have likely
gone too far.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aj-stein-nist aj-stein-nist

Labels
bug Scope: CI/CD Enhancements to the project's Continuous Integration and Continuous Delivery pipeline.
Projects
NIST OSCAL Work Board
Status: Done
Milestone
v1.1.0
1 participant
@aj-stein-nist