Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to "biblio" #1841

Closed
RS-Credentive opened this issue Jul 7, 2023 · 2 comments · Fixed by #1875
Closed

Remove references to "biblio" #1841

RS-Credentive opened this issue Jul 7, 2023 · 2 comments · Fixed by #1875
Assignees
@aj-stein-nist
Labels
bug
Milestone
v1.1.1

Comments

@RS-Credentive
Copy link

https://github.com/usnistgov/OSCAL/blob/ff6a37495955cca4c6205ff243332468564e6f33/src/metaschema/oscal_metadata_metaschema.xml#L471C37-L471C37

In back-matter/resource/citation, there is a reference to a "biblio" type that no longer exists. This definition should be rewritten to eliminate this reference.
@Arminta-Jenkins-NIST Arminta-Jenkins-NIST self-assigned this Jul 13, 2023
@aj-stein-nist
Copy link
Contributor

Having reviewed this, I would recommend this one stay in this repo, since the change will be in the Metaschema module. That stayed here post migration.

@RS-Credentive
Copy link
Author

Makes sense to me

@aj-stein-nist aj-stein-nist added this to the Next milestone Aug 3, 2023
@aj-stein-nist aj-stein-nist self-assigned this Aug 6, 2023
@aj-stein-nist aj-stein-nist moved this from Todo to In Progress in NIST OSCAL Work Board Aug 6, 2023
aj-stein-nist added a commit that referenced this issue Aug 6, 2023
@aj-stein-nist
Remove dead code for biblio for #1841
adaca27 
A community member reported the obsolete references to back-matter/resource/citation biblio element. The documentation that led to the bug report has also since been commented out, this commit will remove both commented out model and documentation.
@aj-stein-nist aj-stein-nist mentioned this issue Aug 6, 2023
Merged
6 tasks
@aj-stein-nist aj-stein-nist linked a pull request Aug 6, 2023 that will close this issue
Remove dead code for biblio element in citations #1875
Merged
6 tasks
@aj-stein-nist aj-stein-nist moved this from In Progress to Under Review in NIST OSCAL Work Board Aug 6, 2023
aj-stein-nist added a commit that referenced this issue Aug 7, 2023
@aj-stein-nist
Remove dead code for biblio for #1841 (#1875)
05ee674 
A community member reported the obsolete references to back-matter/resource/citation biblio element. The documentation that led to the bug report has also since been commented out, this commit will remove both commented out model and documentation.
@aj-stein-nist aj-stein-nist moved this from Under Review to Reviewer Approved in NIST OSCAL Work Board Aug 7, 2023
@aj-stein-nist aj-stein-nist modified the milestones: Next, Ready Now Aug 7, 2023
@aj-stein-nist aj-stein-nist moved this from Reviewer Approved to Done in NIST OSCAL Work Board Aug 7, 2023
aj-stein-nist added a commit that referenced this issue Sep 12, 2023
@aj-stein-nist
Remove dead code for biblio for #1841 (#1875)
e854f81 
A community member reported the obsolete references to back-matter/resource/citation biblio element. The documentation that led to the bug report has also since been commented out, this commit will remove both commented out model and documentation.
Arminta-Jenkins-NIST pushed a commit that referenced this issue Sep 12, 2023
@aj-stein-nist @Arminta-Jenkins-NIST
Remove dead code for biblio for #1841 (#1875)
ac37378 
A community member reported the obsolete references to back-matter/resource/citation biblio element. The documentation that led to the bug report has also since been commented out, this commit will remove both commented out model and documentation.
@aj-stein-nist aj-stein-nist modified the milestones: Ready Now, v1.1.1 Sep 20, 2023
@iMichaela iMichaela mentioned this issue Mar 29, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aj-stein-nist aj-stein-nist

Labels
bug
Projects
NIST OSCAL Work Board
Status: Done
Milestone
v1.1.1
3 participants
@aj-stein-nist @Arminta-Jenkins-NIST @RS-Credentive