Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparing JSON examples produced from the metaschema using multiple tools #244

Closed
anweiss opened this issue Oct 2, 2018 · 3 comments
Closed
Labels
Discussion Needed This issues needs to be reviewed by the OSCAL development team. Scope: Content Development of OSCAL content and examples. Scope: Metaschema Issues targeted at the metaschema pipeline Scope: Modeling Issues targeted at development of OSCAL formats

Comments

@anweiss
Copy link
Contributor

anweiss commented Oct 2, 2018

In support of #197 and #242, below are JSON examples of a catalog and profile which were both produced from oscalkit via the metaschema. These can be compared to the examples produced from the XSLT for validating and fine-tuning the metaschema. Any JSON consolidation constructs embedded into the metaschema as a result of #241, #224 and #202 will also be reflected in future example production runs of oscalkit.

CC @wendellpiez

This issue is meant purely for JSON example comparisons and can be closed once the metaschema is functioning as desired.

@anweiss
Copy link
Contributor Author

anweiss commented Oct 2, 2018

FWIW, oscalkit automatically generates its own code from the metaschemas in ~200 lines of code. The core Go templating logic is contained at https://github.com/opencontrol/oscalkit/blob/master/metaschema/types.tmpl. It's relatively straightforward to enhance this to generate types from the metaschemas for other programming languages.

@david-waltermire david-waltermire added Discussion Needed This issues needs to be reviewed by the OSCAL development team. Scope: Content Development of OSCAL content and examples. Scope: Modeling Issues targeted at development of OSCAL formats Scope: Metaschema Issues targeted at the metaschema pipeline labels May 8, 2019
@david-waltermire
Copy link
Contributor

@anweiss Should this issue be transfered to oscalkit?

@anweiss
Copy link
Contributor Author

anweiss commented Jun 19, 2019

@david-waltermire-nist TBH I think we can actually close this in favor of the metaschema tests that have been implemented as part of CI/CD. Over time, other tools will naturally be able to implement similar tests within their own context.

Closing as such.

@anweiss anweiss closed this as completed Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Needed This issues needs to be reviewed by the OSCAL development team. Scope: Content Development of OSCAL content and examples. Scope: Metaschema Issues targeted at the metaschema pipeline Scope: Modeling Issues targeted at development of OSCAL formats
Projects
None yet
Development

No branches or pull requests

2 participants