Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

857 extension mechanisms #1031

Conversation

Rene2mt
Copy link
Contributor

@Rene2mt Rene2mt commented Sep 30, 2021

Committer Notes

WIP PR that includes changes adding links from the metadata tutorial to the props & links tutorial. Also minor markdown code changes. This PR also has a few minor changes to the props & links tutorial, including links to the metadata tutorial, and updates to the sample code widgets.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

</system-security-plan>
{{< /highlight >}}

The `@name` attribute is set to "type" which is an OSCAL pre-defined property. The `@value` attribute is set to "data-center" which is an OSCAL pre-defined value for location "type" properties. The `@class` attribute in this case is used to indicate a subclass of data-center, and is set the the appropriate OSCAL pre-defined values for data center location properties. Note that in this example, the `@ns` attribute is omitted because we are using a standard OSCAL defined `<prop>` element.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `@name` attribute is set to "type" which is an OSCAL pre-defined property. The `@value` attribute is set to "data-center" which is an OSCAL pre-defined value for location "type" properties. The `@class` attribute in this case is used to indicate a subclass of data-center, and is set the the appropriate OSCAL pre-defined values for data center location properties. Note that in this example, the `@ns` attribute is omitted because we are using a standard OSCAL defined `<prop>` element.
The `@name` attribute is set to "type" which is an OSCAL pre-defined property for a `<location>`. The `@value` attribute is set to "data-center" which is an OSCAL pre-defined value for location "type" properties. The `@class` attribute in this case is used to indicate a subclass of data-center, and is set the the appropriate OSCAL pre-defined values for data center location properties. Note that in this example, the `@ns` attribute is omitted because we are using a standard OSCAL defined `<prop>` element.

Maybe link the "pre-defined" to the related docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added links to metadata->location->prop predefined name and value reference documentation

This was referenced Oct 28, 2021
@david-waltermire david-waltermire merged commit cc9a55c into usnistgov:feature-metadata-extension-tutorial Nov 4, 2021
david-waltermire pushed a commit that referenced this pull request Dec 9, 2021
* edits and updates to metadata tutorial
* updates to extensions tutorial
* added json and yaml example snippets
* updates to props and links
* added link to allowed values documentation
* hugo callouts and minor tweaks
Rene2mt added a commit to Rene2mt/OSCAL that referenced this pull request May 17, 2022
* edits and updates to metadata tutorial
* updates to extensions tutorial
* added json and yaml example snippets
* updates to props and links
* added link to allowed values documentation
* hugo callouts and minor tweaks
david-waltermire pushed a commit that referenced this pull request May 17, 2022
* edits and updates to metadata tutorial
* updates to extensions tutorial
* added json and yaml example snippets
* updates to props and links
* added link to allowed values documentation
* hugo callouts and minor tweaks
david-waltermire pushed a commit that referenced this pull request Jul 14, 2022
* edits and updates to metadata tutorial
* updates to extensions tutorial
* added json and yaml example snippets
* updates to props and links
* added link to allowed values documentation
* hugo callouts and minor tweaks
david-waltermire added a commit that referenced this pull request Jul 25, 2022
* Adding metadata tutorial page
* Fixing links to match new link contract
* updated rlink reference
* 857 extension mechanisms (#1031)
* Added json and yaml example snippets
* Added link to allowed values documentation
* Added hugo callouts and minor tweaks
* 857 updates (#1273)
* Completed an editorial pass through the metadata and extension tutorial. Revised the prop portion of the extension tutorial to provide a better conceptualization
* Reorganized the tutorials to follow the model layer organization.

Co-authored-by: David Waltermire <david.waltermire@nist.gov>
Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
Co-authored-by: stephenbanghart <banghasa@dukes.jmu.edu>
Co-authored-by: Stephen Banghart <stephen.banghart@nist.gov>
Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@noblis.org>
Co-authored-by: Rene2mt <76444659+Rene2mt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants