Convert File Type for Files or Remote Hyperlinks in Continuous Deployment #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment (#1010) * First attempt at Python script to clean up extensions. * Add Python deps manifest. * Update Dockerfile with Python dependencies. * Remove additive dot before file ext and try out adding to CI harness. * Add first attempt of Python converter. * updated the tools table * Rename handler function accordingly, so docs make sense. * Fix bug with hard-coded conversion for JSON processing. * Add some more function documentation. * Complete update of function docstrings. * A little more function documentation. * Final function signature touch-ups. Co-authored-by: Michaela Iorga <michaela.iorga@nist.gov> Co-authored-by: David Waltermire <david.waltermire@nist.gov>
4 tasks
aj-stein-nist
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
I am Alexander Stein and I approve this message.
Jokes aside, we tested this works locally in the docker containers invoking the same scripts used by CI/CD (GitHub Actions) and verified they function as desired. Confirmed with Dave superficial YAML difference are acceptable for escaping multi-line comments and we made a best-effort attempt at get line-for-line parity.
aj-stein-nist
approved these changes
Jan 21, 2022
david-waltermire
deleted the
feature-oscal-content-59-convert-file-paths
branch
This was referenced Jan 21, 2022
iMichaela
added a commit
to iMichaela/OSCAL
that referenced
this pull request
Apr 7, 2022
…ment (usnistgov#1070) * Convert File Type for Files or Remote Hyperlinks in Continuous Deployment (usnistgov#1010) * First attempt at Python script to clean up extensions. * Add Python deps manifest. * Update Dockerfile with Python dependencies. * Remove additive dot before file ext and try out adding to CI harness. * Add first attempt of Python converter. * updated the tools table * Rename handler function accordingly, so docs make sense. * Fix bug with hard-coded conversion for JSON processing. * Add some more function documentation. * Complete update of function docstrings. * A little more function documentation. * Final function signature touch-ups. Co-authored-by: Michaela Iorga <michaela.iorga@nist.gov> Co-authored-by: David Waltermire <david.waltermire@nist.gov> * fix python calls to use correct python version and script Co-authored-by: Alexander Stein (Inactive) <61464190+ohsh6o@users.noreply.github.com> Co-authored-by: Michaela Iorga <michaela.iorga@nist.gov>
Rene2mt
pushed a commit
to Rene2mt/OSCAL
that referenced
this pull request
May 17, 2022
…ment (usnistgov#1070) * Convert File Type for Files or Remote Hyperlinks in Continuous Deployment (usnistgov#1010) * First attempt at Python script to clean up extensions. * Add Python deps manifest. * Update Dockerfile with Python dependencies. * Remove additive dot before file ext and try out adding to CI harness. * Add first attempt of Python converter. * updated the tools table * Rename handler function accordingly, so docs make sense. * Fix bug with hard-coded conversion for JSON processing. * Add some more function documentation. * Complete update of function docstrings. * A little more function documentation. * Final function signature touch-ups. Co-authored-by: Michaela Iorga <michaela.iorga@nist.gov> Co-authored-by: David Waltermire <david.waltermire@nist.gov> * fix python calls to use correct python version and script Co-authored-by: Alexander Stein (Inactive) <61464190+ohsh6o@users.noreply.github.com> Co-authored-by: Michaela Iorga <michaela.iorga@nist.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
This PR, as part of enhancements to the current CD pipeline will fix relevant missed conversions between XML and JSON and YAML filetypes, and their respective MIME types, in place of
perlandsedissues. This will fix usnistgov/oscal-content#59 and GSA/fedramp-automation#129 on an ongoing basis.All Submissions:
Changes to Core Features:
Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.