Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NEW CONTENT comment blocks #1179

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Remove NEW CONTENT comment blocks #1179

merged 1 commit into from
Mar 18, 2022

Conversation

guyzyl
Copy link
Contributor

@guyzyl guyzyl commented Mar 16, 2022 •
edited by aj-stein-nist
Loading

Committer Notes

Removed the following comment blocks from the metaschemas:

  • NEW CONTENT
  • END NEW CONTENT
  • NEW
  • END NEW

This fixes #1176

All Submissions:

@aj-stein-nist aj-stein-nist linked an issue Mar 16, 2022 that may be closed by this pull request
NEW CONTENT comment in metaschemas #1176
Closed
aj-stein-nist
aj-stein-nist previously approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚢

@aj-stein-nist aj-stein-nist changed the base branch from develop to release-1.0 March 18, 2022 17:39
@aj-stein-nist aj-stein-nist changed the base branch from release-1.0 to develop March 18, 2022 17:39
@aj-stein-nist aj-stein-nist dismissed their stale review March 18, 2022 17:39

The base branch was changed.

@david-waltermire david-waltermire changed the base branch from develop to release-1.0 March 18, 2022 17:53
@guyzyl @david-waltermire
Remove NEW CONTENT comment blocks
f87ba3e 
Also removed the related blocks:
- `END NEW CONTENT`
- `NEW`
- `END NEW`

This fixes usnistgov#1176
david-waltermire
david-waltermire approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@aj-stein-nist aj-stein-nist added this to the OSCAL 1.0.2 milestone Mar 18, 2022
@aj-stein-nist aj-stein-nist merged commit 76339bd into usnistgov:release-1.0 Mar 18, 2022
@guyzyl guyzyl deleted the fix-1176 branch March 18, 2022 18:35
david-waltermire pushed a commit that referenced this pull request Mar 18, 2022
@guyzyl @david-waltermire
Remove NEW CONTENT comment blocks (#1179)
8f7189c 
Also removed the related blocks:
- `END NEW CONTENT`
- `NEW`
- `END NEW`

This fixes #1176
iMichaela pushed a commit to iMichaela/OSCAL that referenced this pull request Apr 7, 2022
@guyzyl @iMichaela
Remove NEW CONTENT comment blocks (usnistgov#1179)
94bdc28 
Also removed the related blocks:
- `END NEW CONTENT`
- `NEW`
- `END NEW`

This fixes usnistgov#1176
Rene2mt pushed a commit to Rene2mt/OSCAL that referenced this pull request May 17, 2022
@guyzyl @Rene2mt
Remove NEW CONTENT comment blocks (usnistgov#1179)
92c5ba4 
Also removed the related blocks:
- `END NEW CONTENT`
- `NEW`
- `END NEW`

This fixes usnistgov#1176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-waltermire david-waltermire david-waltermire approved these changes

@aj-stein-nist aj-stein-nist aj-stein-nist left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
OSCAL 1.0.2
Development

Successfully merging this pull request may close these issues.

NEW CONTENT comment in metaschemas
3 participants
@guyzyl @david-waltermire @aj-stein-nist