Integration of Profile Resolution NG into Build Process #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
david-waltermire
changed the title
This was
linked to
issues
Feb 7, 2020
bradh
reviewed
Feb 13, 2020
| created under \$TMPDIR if set or in /tmp. | ||
| --keep-temp-scratch-dir If a scratch directory is automatically | ||
| created, it will not be automatically removed. | ||
| -v Provide verbose output |
There was a problem hiding this comment.
Maybe add a --verbose equivalent for consistency and ease-of-reading.
| case "$arg" in | ||
| --scratch-dir) | ||
| SCRATCH_DIR="$(realpath "$2")" | ||
| shift # past unit_test_dir |
There was a problem hiding this comment.
The comment should probably refer to the scratch dir.
| echo -e "${P_INFO}==============================${P_END}" | ||
|
|
||
| if [ "$VERBOSE" = "true" ]; then | ||
| echo -e "${P_INFO}Using working directory:${P_END} ${WORKING_DIR}" |
There was a problem hiding this comment.
Doesn't look like this gets set here.
xml/schema/oscal_catalog_schema.xsd
Outdated
| <xs:element ref="oscal-catalog:param" minOccurs="0" maxOccurs="unbounded"/> | ||
| <xs:element ref="oscal-catalog:control" minOccurs="0" maxOccurs="unbounded"/> | ||
| <xs:element ref="oscal-catalog:group" minOccurs="0" maxOccurs="unbounded"/> | ||
| <xs:choice> |
There was a problem hiding this comment.
This looks like a change from (or for) a different commit.
4 tasks
4 tasks
These are selective imports from the catalogs/abc-simple_catalog.xml, essentially identical except for how the catalog is referenced.
…le (#16) This is basically the entire catalog, except for the a1 profile. The change adds the parent groups, and the children of c1.
This is essentially the same as the catalog, and adds the parent groups to the existing result.
This adds the parent group, missing params and parts of the control.
This is basically the same as the catalog, less the children on c1
Adds the parent group and title, and missing control c3.a-1
These are essentially identical, since keep is the default.
david-waltermire
force-pushed
the
daw-profile-resolution-ng-repaired
branch
from
d82ae87
to
7ce3f73
Compare
Added config option to support profile-resolution. Updating to latest metaschema. Fixes to profile catalog references to make them relative.
* fixing a profile resolution bug causing duplicate back-matter when multiple catalogs are used.,
Fixed profile resolution validation errors resulting from invalid catalogs.
This was
linked to
issues
Mar 27, 2020
4 tasks
Fixed broken schema path in test-profile-resolution.sh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Addressing #561 and usnistgov/oscal-content#128 by implementing profile resolution unit testing.
This PR leverages the commits from PR #559.
All Submissions:
Changes to Core Features: