Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modeling refactoring based on feedback (session 3) #643

Conversation

david-waltermire
Copy link
Contributor

Committer Notes

Further work on addressing feedback related to issue #597.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

david-waltermire and others added 8 commits May 29, 2020 21:04
Implemented uuids addressing issue usnistgov#676.
Migrated definition of a system interconnection and service into components. The "service" and "interconnection" component types are now used to define these. (usnistgov#498)
Flattened party -> org/person to be just party. Party now has a type which identifies if the party is a person or organization.
Added SHA-3 algorithms to the hash algorithm list. (usnistgov#632)
@david-waltermire david-waltermire linked an issue May 31, 2020 that may be closed by this pull request
3 tasks
Fixed SSP elements that reference a component UUID, but lacked the correct type.
…g type of conversion as compared to what was actually happening.

Fixed remaining round-trip issues.
@david-waltermire
Copy link
Contributor Author

This PR was incorporated into PR #681.

@david-waltermire david-waltermire deleted the issue597-refactoring-session-3 branch June 1, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance schemas to support more digest methods OSCAL SSP schema review against an actual SSP Template
3 participants