Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematron support upgrade with refurb (Recreated with rewritten history) #49

Conversation

nikitawootten-nist
Copy link
Collaborator

@nikitawootten-nist nikitawootten-nist commented Jul 21, 2023

WIP towards updating Schematron support for Metaschema

  • Updated metaschema-composition-check.sch Schematron now works with schxslt XSLT transpiler not only the old 'Skeleton' transpiler
  • XProcs for applying this Schematron to metaschema are provided - one for each transpiler under XML Calabash
  • A copy of schxslt is provided (but not as a submodule - revisit this?) for a complete runtime

In this PR I edited the history to remove the schxslt zip file and vendored content.

Committer Notes

With this commit we have several more options for providing Schematron support.

More work may need to be done to optimize Schematron outputs (using the new svrl-reduce.xsl filter), then integrating.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@nikitawootten-nist nikitawootten-nist requested a review from a team as a code owner July 21, 2023 18:36
@nikitawootten-nist nikitawootten-nist force-pushed the issue41-schematron-setup-submoduled branch from d65b64c to f821678 Compare July 21, 2023 18:38
@nikitawootten-nist nikitawootten-nist changed the title [DRAFT] Schematron support upgrade with refurb (Recreated with rewritten history) Schematron support upgrade with refurb (Recreated with rewritten history) Jul 21, 2023
* Remove schematron submodule
* Add smoke test for compose validation
* Make all scripts executable
@nikitawootten-nist nikitawootten-nist force-pushed the issue41-schematron-setup-submoduled branch from 2b64add to e749ad3 Compare July 21, 2023 18:46
@nikitawootten-nist
Copy link
Collaborator Author

Merging with verbal approval of the team 🎉

@nikitawootten-nist nikitawootten-nist merged commit f51ba47 into usnistgov:develop Jul 21, 2023
@nikitawootten-nist nikitawootten-nist deleted the issue41-schematron-setup-submoduled branch July 21, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants