Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct XProc Pipelines Relative Paths, Stop Runtime Exceptions #256

Conversation

aj-stein-nist
Copy link
Collaborator

@aj-stein-nist aj-stein-nist commented Nov 14, 2022

Committer Notes

{Please provide a brief description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please include [WIP] at the beginning of the title or mark the PR as DRAFT.}

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@aj-stein-nist aj-stein-nist added bug Something isn't working XSLT Implementation Issue relates to the XSLT implementation of Metaschema. labels Nov 14, 2022
@aj-stein-nist aj-stein-nist self-assigned this Nov 14, 2022
@aj-stein-nist aj-stein-nist changed the base branch from main to develop November 14, 2022 23:14
@aj-stein-nist aj-stein-nist linked an issue Nov 14, 2022 that may be closed by this pull request
@aj-stein-nist aj-stein-nist force-pushed the 255-debugging-xproc-pipelines-using-outdated-paths branch from 9470e05 to 3499fde Compare November 17, 2022 04:00
@aj-stein-nist
Copy link
Collaborator Author

I updated a Schematron used to query and validate paths of all necessary @hrefs and validate them. I did comment out dead code on some XProc pipelines that are old enough I cannot find a better solution.

@aj-stein-nist aj-stein-nist marked this pull request as ready for review November 17, 2022 04:06
Copy link
Collaborator

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, thanks AJ!

@david-waltermire david-waltermire force-pushed the 255-debugging-xproc-pipelines-using-outdated-paths branch from 3499fde to f235402 Compare December 7, 2022 03:43
@david-waltermire david-waltermire merged commit 28872af into usnistgov:develop Dec 7, 2022
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this pull request Jan 9, 2023
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this pull request Jan 10, 2023
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this pull request Jan 10, 2023
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this pull request Jan 10, 2023
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this pull request Jan 10, 2023
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working XSLT Implementation Issue relates to the XSLT implementation of Metaschema.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugging XProc Pipelines Using Outdated Paths
3 participants