-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Metaschema Tutorial #275
Basic Metaschema Tutorial #275
Conversation
84f9a8a
to
ddd0d04
Compare
Feedback from @brianruf and @jimstevensedc: this tutorial and/or potentially future tutorials should cover two perspectives, clearly and intentionally:
|
@david-waltermire-nist also asked for me in a call to do the following before asking for re-review:
|
4fe822f
to
53836c8
Compare
Ok @david-waltermire-nist, done and ready for review. |
The build failure, FYI, is waiting on #278 to build successfully in main. |
53836c8
to
d68c40e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Thanks AJ!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly suggesting corrections to typos with a couple more substantial offerings.
Bravo AJ!
dbbd1ca
to
9d851c2
Compare
9d851c2
to
07044b0
Compare
@wendellpiez I included all the feedback you provided in your previous review. I will do a final pass for minor typos, but I need you, @david-waltermire-nist, or @nikitawootten-nist. I might find a typo or two, but it is ready to go. |
07044b0
to
1636ada
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went over this together looking good!
Committer Notes
Add basic metaschema tutorial for #260.
All Submissions:
Changes to Core Features:
Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.