Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad profile and catalog links to XML/JSON Revision 4 Content #180

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Fix bad profile and catalog links to XML/JSON Revision 4 Content #180

merged 1 commit into from
Jan 31, 2023

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Jan 31, 2023 •
edited
Loading

Committer Notes

Closes #179.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?

@aj-stein-nist aj-stein-nist requested a review from a team January 31, 2023 16:02
@aj-stein-nist aj-stein-nist self-assigned this Jan 31, 2023
wendellpiez
wendellpiez approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@aj-stein-nist aj-stein-nist merged commit 00660bd into usnistgov:main Jan 31, 2023
@aj-stein-nist aj-stein-nist deleted the 179-link-to-json-catalog-in-source-directory-readme-is-wrong branch January 31, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitawootten-nist nikitawootten-nist nikitawootten-nist approved these changes

@wendellpiez wendellpiez wendellpiez approved these changes

Assignees

@aj-stein-nist aj-stein-nist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link to JSON Catalog in Source Directory README is wrong
3 participants
@aj-stein-nist @wendellpiez @nikitawootten-nist