Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json content pointing to xml profiles/catalog #91

Closed
wants to merge 1 commit into from

Conversation

guyzyl
Copy link

@guyzyl guyzyl commented Jan 27, 2022

Committer Notes

I noticed that the JSON content in nist.gov/SP800-53 is pointing to their .xml catalog/profiles counterparts.
This PR fixes the issue, the the JSON content is now pointing to .json catalog/profiles.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

@aj-stein-nist
Copy link
Contributor

Thanks for the PR, but I believe this one is only going to fix the system, not the disease. :-)

Please refer to #59 and the PR merged earlier this week for the upcoming release, usnistgov/OSCAL#1070. These files are generated programmatically from the ./oscal submodule (and subdirectory's) CI/CD scripts. The resulting files are here, but they are generated from ./src/nist.gov as you can see from tracing the script inputs and outputs. All these changes will be overwritten.

Per the issue above, once we update the submodule in an upcoming PR, we can close #59 and this will be handled automatically, no manual editing needed! :-)

@aj-stein-nist
Copy link
Contributor

@david-waltermire-nist this is a dupe and I don't have access for this repo so you can choose if you want to close or how we ought to handle this one. :-)

@guyzyl
Copy link
Author

guyzyl commented Jan 27, 2022

@aj-stein-nist got it, I'll close this PR then.

@guyzyl guyzyl closed this Jan 27, 2022
@aj-stein-nist
Copy link
Contributor

@guyzyl thanks for trying though. I had asked about this long ago, so eventually I found the source of the problem. The patch release is coming soon, I want to see this done and done! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants