This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
use multistage build Dockerfile #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingles
reviewed
Aug 13, 2018
.drone.yml
Outdated
| image: golang:1.10 | ||
| commands: | ||
| - make build-linux | ||
| # build: |
There was a problem hiding this comment.
Could you delete the commented section please
| @@ -0,0 +1,4 @@ | |||
| bin | |||
There was a problem hiding this comment.
Could this include .git also?
Thanks for adding this- be useful to exclude as much as we can.
Dockerfile
Outdated
| RUN apk add --no-cache make | ||
| WORKDIR /go/src/github.com/uswitch/kiam | ||
| ADD . . | ||
| RUN make proto/service.pb.go build-linux |
There was a problem hiding this comment.
Could we simplify the Makefile so that the default is to build the binary and have it manage the rest please?
|
something like this? |
pingles
approved these changes
Aug 13, 2018
|
Thanks @roffe |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100