Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logs directory #661

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Conversation

200km
Copy link
Member

@200km 200km commented Jul 20, 2024

Related issues

#613

Description

The logs directory was moved from the data/sample to the root directory.

Test results

See CI.

Impact

NA

Supplementary information

NA

@200km 200km added priority::medium priority medium tools gui graphical user interface major update incompatible API changes labels Jul 20, 2024
@200km 200km added this to the Major Update v8.0.0 milestone Jul 20, 2024
@200km 200km self-assigned this Jul 20, 2024
@200km 200km requested review from sksat and a team as code owners July 20, 2024 09:13
@200km 200km requested review from ogoogo, Hiro-0110, seki-hiro, suzuki-toshihir0, t-hosonuma and conjikidow and removed request for a team July 20, 2024 09:13
@200km 200km added the automation::comment-graph comment simulation result graph on pull request label Jul 20, 2024
@conjikidow
Copy link
Member

ありがとうございます,確認が遅くなりすみません。
merge先だけ気になったので,必要であれば修正をお願いします。

@200km
Copy link
Member Author

200km commented Aug 8, 2024

@conjikidow レビューありがとうございます。他のものも全て混ざったPRなので、他のレビューが完了したら適切にマージ先など処理していきます。

@200km 200km merged commit 295c4c4 into feature/modify-settings Aug 8, 2024
1 check passed
@200km 200km deleted the feature/move-logs-directory branch August 8, 2024 22:25
@200km 200km mentioned this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation::comment-graph comment simulation result graph on pull request gui graphical user interface major update incompatible API changes priority::medium priority medium tools
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants